From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: adrian.hunter@intel.com, ulfh@kernel.org, p.zabel@pengutronix.de,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: sdhci-of-dwcmshc: improve delay handling with fsleep()
Date: Mon, 18 May 2026 17:16:40 +0300 [thread overview]
Message-ID: <agsfSBAmxzd1lIg8@ashevche-desk.local> (raw)
In-Reply-To: <20260518110034.142587-2-a.shimko.dev@gmail.com>
On Mon, May 18, 2026 at 02:00:31PM +0300, Artem Shimko wrote:
> The driver currently uses udelay() for short delays, which performs
> busy-waiting and may not be optimal even for very short durations.
> While udelay() is appropriate for atomic context, these specific delays
> occur in non-atomic contexts where sleeping is allowed.
>
> Replace udelay(1) with fsleep(1) in dwcmshc_rk3568_set_clock() and
> rk35xx_sdhci_reset(). The fsleep() function automatically selects the
> optimal delay mechanism based on the requested duration - for
> delays <= 10 microseconds it will use udelay() internally, but provides
> better flexibility for future adjustments and makes the code more
> consistent with kernel best practices. No functional change is intended.
Read, what you wrote. With the above commit message this is no point in this
patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-18 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 11:00 [PATCH 0/3] mmc: sdhci-of-dwcmshc: Minor cleanups Artem Shimko
2026-05-18 11:00 ` [PATCH 1/3] mmc: sdhci-of-dwcmshc: improve delay handling with fsleep() Artem Shimko
2026-05-18 14:16 ` Andy Shevchenko [this message]
2026-05-18 14:50 ` Artem Shimko
2026-05-18 18:35 ` Andy Shevchenko
2026-05-19 15:43 ` Artem Shimko
2026-05-18 11:00 ` [PATCH 2/3] mmc: sdhci-of-dwcmshc: remove redundant IS_ERR() check Artem Shimko
2026-05-20 6:18 ` Adrian Hunter
2026-05-18 11:00 ` [PATCH 3/3] mmc: sdhci-of-dwcmshc: use dev_err_probe() to simplify error paths Artem Shimko
2026-05-20 6:18 ` Adrian Hunter
2026-05-20 7:14 ` Artem Shimko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agsfSBAmxzd1lIg8@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=a.shimko.dev@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®