From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: adrian.hunter@intel.com, ulfh@kernel.org, p.zabel@pengutronix.de,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: sdhci-of-dwcmshc: improve delay handling with fsleep()
Date: Mon, 18 May 2026 21:35:01 +0300 [thread overview]
Message-ID: <agtb1VVEaOamRnEl@ashevche-desk.local> (raw)
In-Reply-To: <CAOPX746JbZamfeJcY+vT1EWDpFCSVe4zc8AHGL8sGobUnzC9ew@mail.gmail.com>
On Mon, May 18, 2026 at 05:50:55PM +0300, Artem Shimko wrote:
> On Mon, May 18, 2026 at 5:16 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > Read, what you wrote. With the above commit message this is no point in this
> > patch.
>
> I tried to replace *sleep() with fsleep() API. It seems I
> misunderstood the hint [1].
Yep, the hint was basically about uses of usleep_range(). udelay for 1 or 2
microseconds is fine as is. Of course for the sake of consistency it can be
moved to fsleep() (when the context is non-atomic), but solely udelay(1) -->
fsleep(1) makes no needed churn.
> Or is that the commit description mistake?
>
> Thank you for reviewing it.
>
> [1] https://lore.kernel.org/all/ad-mCsvOWWgqt-rc@ashevche-desk.local/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-18 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 11:00 [PATCH 0/3] mmc: sdhci-of-dwcmshc: Minor cleanups Artem Shimko
2026-05-18 11:00 ` [PATCH 1/3] mmc: sdhci-of-dwcmshc: improve delay handling with fsleep() Artem Shimko
2026-05-18 14:16 ` Andy Shevchenko
2026-05-18 14:50 ` Artem Shimko
2026-05-18 18:35 ` Andy Shevchenko [this message]
2026-05-19 15:43 ` Artem Shimko
2026-05-18 11:00 ` [PATCH 2/3] mmc: sdhci-of-dwcmshc: remove redundant IS_ERR() check Artem Shimko
2026-05-20 6:18 ` Adrian Hunter
2026-05-18 11:00 ` [PATCH 3/3] mmc: sdhci-of-dwcmshc: use dev_err_probe() to simplify error paths Artem Shimko
2026-05-20 6:18 ` Adrian Hunter
2026-05-20 7:14 ` Artem Shimko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agtb1VVEaOamRnEl@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=a.shimko.dev@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®