mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Inochi Amaoto <inochiama@gmail.com>,
	Ulf Hansson <ulfh@kernel.org>,
	Karol Gugala <kgugala@antmicro.com>,
	Mateusz Holenko <mholenko@antmicro.com>,
	Joel Stanley <joel@jms.id.au>,
	Kamil Rakoczy <krakoczy@antmicro.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH v4] mmc: litex_mmc: Set mandatory idle clocks before CMD0
Date: Tue, 19 May 2026 19:48:15 -0400	[thread overview]
Message-ID: <agz2v0EHaffzoXxB@errol.ini.cmu.edu> (raw)
In-Reply-To: <CAHp75VfruMEp++65kFtMt=Em-bF2d1jMUywT-6ropx6cTHFygw@mail.gmail.com>

On Tue, May 19, 2026 at 10:52:10AM +0300, Andy Shevchenko wrote:
> On Tue, May 19, 2026 at 5:51 AM Inochi Amaoto <inochiama@gmail.com> wrote:
> > On Mon, May 18, 2026 at 06:45:26PM -0400, Gabriel L. Somlo wrote:
> 
> ...
> 
> >         /* Update sd_clk */
> > -       if (ios->clock != host->sd_clk)
> > +       if (ios->clock != host->sd_clk) {
> >                 litex_mmc_setclk(host, ios->clock);
> > +       }
> 
> FWIW, it's a stray change.

and I'm still getting:

[    6.508084] mmc0: invalid bus width
[    6.510652] mmc0: error -22 whilst initialising SD card

when booting with this change on 64-bit litex/rocket.

Thanks,
--Gabriel

      reply	other threads:[~2026-05-19 23:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17  1:53 Inochi Amaoto
2026-05-18 22:20 ` Gabriel L. Somlo
2026-05-18 22:24   ` Inochi Amaoto
2026-05-18 22:45     ` Gabriel L. Somlo
2026-05-19  1:11       ` Inochi Amaoto
2026-05-19  2:51       ` Inochi Amaoto
2026-05-19  7:52         ` Andy Shevchenko
2026-05-19 23:48           ` Gabriel L. Somlo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agz2v0EHaffzoXxB@errol.ini.cmu.edu \
    --to=gsomlo@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dlan@gentoo.org \
    --cc=inochiama@gmail.com \
    --cc=joel@jms.id.au \
    --cc=kgugala@antmicro.com \
    --cc=krakoczy@antmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=looong.bin@gmail.com \
    --cc=mholenko@antmicro.com \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®