From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: joshua.crofts1@gmail.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/8] iio: light: opt3001: use local struct device and i2c_client variables
Date: Tue, 2 Jun 2026 13:43:27 +0300 [thread overview]
Message-ID: <ah6zz6AtxKmyFibn@ashevche-desk.local> (raw)
In-Reply-To: <20260525-opt3001-cleanup-v4-2-65b36a174f78@gmail.com>
On Mon, May 25, 2026 at 10:20:16AM +0200, Joshua Crofts via B4 Relay wrote:
>
> Switch the driver to use local variables for struct device and struct
> i2c_client and remove struct device member from struct opt3001, as the
> former can be derived from struct client.
>
> While at it, ensure that parentheses alignment is correct in functions
> that were changed in this patch.
>
> No functional change.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-02 10:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 8:20 [PATCH v4 0/8] iio: light: opt3001: driver cleanup Joshua Crofts via B4 Relay
2026-05-25 8:20 ` [PATCH v4 1/8] iio: light: opt3001: move device registration to end of probe() Joshua Crofts via B4 Relay
2026-05-25 9:06 ` Joshua Crofts
2026-05-27 18:19 ` Jonathan Cameron
2026-05-25 8:20 ` [PATCH v4 2/8] iio: light: opt3001: use local struct device and i2c_client variables Joshua Crofts via B4 Relay
2026-06-02 10:43 ` Andy Shevchenko [this message]
2026-05-25 8:20 ` [PATCH v4 3/8] iio: light: opt3001: ensure correct parenthesis alignment Joshua Crofts via B4 Relay
2026-05-27 18:30 ` Jonathan Cameron
2026-05-28 7:10 ` Joshua Crofts
2026-05-25 8:20 ` [PATCH v4 4/8] iio: light: opt3001: localize for loop iterator Joshua Crofts via B4 Relay
2026-05-25 22:52 ` Maxwell Doose
2026-05-25 8:20 ` [PATCH v4 5/8] iio: light: opt3001: prefer dev_err_probe() Joshua Crofts via B4 Relay
2026-05-25 20:48 ` Maxwell Doose
2026-05-25 8:20 ` [PATCH v4 6/8] iio: light: opt3001: move driver to guard(mutex)() use Joshua Crofts via B4 Relay
2026-05-25 8:20 ` [PATCH v4 7/8] iio: light: opt3001: switch driver to managed resources Joshua Crofts via B4 Relay
2026-05-27 18:24 ` Jonathan Cameron
2026-05-25 8:20 ` [PATCH v4 8/8] iio: light: opt3001: add comment to mutex Joshua Crofts via B4 Relay
2026-05-25 10:38 ` [PATCH v4 0/8] iio: light: opt3001: driver cleanup Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah6zz6AtxKmyFibn@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®