From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] misc: pch_phub: Two cleanups
Date: Sun, 24 May 2026 12:12:19 +0200 [thread overview]
Message-ID: <ahLOvzzJt7yUtm3U@monoceros> (raw)
In-Reply-To: <cover.1779360001.git.u.kleine-koenig@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
Hello Greg,
On Thu, May 21, 2026 at 12:46:34PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> my objective is to convert all pci_device_id assignments to use named
> initializer for a further cleanup. See
> https://lore.kernel.org/all/20260507074102.2654314-2-u.kleine-koenig@baylibre.com/
> for details about that.
>
> While working on the pch_phub driver, I found a few more opportunities
> for improvement and the conversion to named initializers is just a side
> effect of the 2nd patch.
>
> If a "= 1" was added to the definition of PCH_EG20T in patch #2, there would be
> no differences in the generated code. Without that there is a shift in the
> magic constants that doesn't change the semantics however.
Sashiko[1] found a few issues in this series that I'd like to address. Can
you please drop this series from your queue?
Best regards
Uwe
[1] https://sashiko.dev/#/patchset/cover.1779360001.git.u.kleine-koenig%40baylibre.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-05-24 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 10:46 Uwe Kleine-König (The Capable Hub)
2026-05-21 10:46 ` [PATCH v1 1/2] misc: pch_phub: Drop two unused functions Uwe Kleine-König (The Capable Hub)
2026-05-21 10:46 ` [PATCH v1 2/2] misc: pch_phub: Introduce an enum for device indentification Uwe Kleine-König (The Capable Hub)
2026-05-24 10:12 ` Uwe Kleine-König (The Capable Hub) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahLOvzzJt7yUtm3U@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®