From: Carlos Maiolino <cem@kernel.org>
To: Yingjie Gao <gaoyingjie@uniontech.com>
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] xfs: fix CoW fork repair error handling
Date: Tue, 26 May 2026 16:51:18 +0200 [thread overview]
Message-ID: <ahWzV0EbYabFf1fx@nidhogg.toxiclabs.cc> (raw)
In-Reply-To: <20260526123243.1078867-1-gaoyingjie@uniontech.com>
On Tue, May 26, 2026 at 08:32:41PM +0800, Yingjie Gao wrote:
> Hi all,
>
> This series fixes two error handling bugs in the CoW fork repair code.
>
> The non-realtime helper can lose real failures in two different ways:
> it returns success after the common cleanup labels, and the
> force-rebuild path can return directly without freeing the AG repair
> context.
>
> The realtime helper has a related cleanup bug in its force-rebuild
> path. If marking the full mapping fails, the code jumps past the
> rtgroup scrub cleanup and only drops the local rtgroup reference.
>
> Split the fixes into two patches so that the non-RT and RT changes
> remain easy to review and bisect independently.
>
> Patches in this series:
> 1. fix non-RT CoW fork repair error returns and cleanup
> 2. fix RT CoW fork repair cleanup
Was this generated by any LLM model?
>
> Thanks,
> Yingjie
>
> Yingjie Gao (2):
> xfs: fix error returns in CoW fork repair
> xfs: fix rtgroup cleanup in CoW fork repair
>
> fs/xfs/scrub/cow_repair.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2026-05-26 14:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 12:32 Yingjie Gao
2026-05-26 12:32 ` [PATCH 1/2] xfs: fix error returns in CoW fork repair Yingjie Gao
2026-05-26 14:52 ` Carlos Maiolino
2026-05-26 12:32 ` [PATCH 2/2] xfs: fix rtgroup cleanup " Yingjie Gao
2026-05-26 14:53 ` Carlos Maiolino
2026-05-26 14:51 ` Carlos Maiolino [this message]
2026-05-27 3:38 ` [PATCH 0/2] xfs: fix CoW fork repair error handling Yingjie Gao
2026-05-27 3:39 ` [PATCH v2 " Yingjie Gao
2026-05-27 3:39 ` [PATCH v2 1/2] xfs: fix error returns in CoW fork repair Yingjie Gao
2026-05-27 3:39 ` [PATCH v2 2/2] xfs: fix rtgroup cleanup " Yingjie Gao
2026-05-27 4:31 ` [PATCH v3 0/2] xfs: fix CoW fork repair error handling Yingjie Gao
2026-05-27 4:31 ` [PATCH v3 1/2] xfs: fix error returns in CoW fork repair Yingjie Gao
2026-05-28 4:44 ` Darrick J. Wong
2026-05-28 8:08 ` Carlos Maiolino
2026-05-27 4:31 ` [PATCH v3 2/2] xfs: fix rtgroup cleanup " Yingjie Gao
2026-05-28 4:45 ` Darrick J. Wong
2026-05-30 6:40 ` [PATCH v3 0/2] xfs: fix CoW fork repair error handling Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahWzV0EbYabFf1fx@nidhogg.toxiclabs.cc \
--to=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=gaoyingjie@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®