From: Carlos Maiolino <cem@kernel.org>
To: Yingjie Gao <gaoyingjie@uniontech.com>
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: fix rtgroup cleanup in CoW fork repair
Date: Tue, 26 May 2026 16:53:48 +0200 [thread overview]
Message-ID: <ahWzvgOLcXKTLyPq@nidhogg.toxiclabs.cc> (raw)
In-Reply-To: <20260526123243.1078867-3-gaoyingjie@uniontech.com>
On Tue, May 26, 2026 at 08:32:43PM +0800, Yingjie Gao wrote:
> The realtime CoW fork repair scan initializes scrub rtgroup state
> before it checks whether the whole mapping should be rebuilt. That
> state includes realtime btree cursors, rtgroup locks, and an extra
> sr->rtg reference.
>
> If marking the full mapping fails in the force-rebuild path, the code
> jumps directly to out_rtg. That only drops the local rtgroup reference
> and skips the scrub rtgroup cleanup, leaving the cursors, lock, and
> sr->rtg reference behind.
>
> Jump to out_sr instead so this error path matches the other failures
> after xrep_rtgroup_init().
>
> Fixes: fd97fe111208 ("xfs: fix CoW forks for realtime files")
> Signed-off-by: Yingjie Gao <gaoyingjie@uniontech.com>
> ---
> fs/xfs/scrub/cow_repair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/scrub/cow_repair.c b/fs/xfs/scrub/cow_repair.c
> index bc3838bac71a..bff25cf74e29 100644
> --- a/fs/xfs/scrub/cow_repair.c
> +++ b/fs/xfs/scrub/cow_repair.c
> @@ -389,7 +389,7 @@ xrep_cow_find_bad_rt(
> error = xrep_cow_mark_file_range(xc, xc->irec.br_startblock,
> xc->irec.br_blockcount);
> if (error)
> - goto out_rtg;
> + goto out_sr;
Ditto for this patch.
> }
>
> out_sr:
> --
> 2.20.1
>
>
next prev parent reply other threads:[~2026-05-26 14:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 12:32 [PATCH 0/2] xfs: fix CoW fork repair error handling Yingjie Gao
2026-05-26 12:32 ` [PATCH 1/2] xfs: fix error returns in CoW fork repair Yingjie Gao
2026-05-26 14:52 ` Carlos Maiolino
2026-05-26 12:32 ` [PATCH 2/2] xfs: fix rtgroup cleanup " Yingjie Gao
2026-05-26 14:53 ` Carlos Maiolino [this message]
2026-05-26 14:51 ` [PATCH 0/2] xfs: fix CoW fork repair error handling Carlos Maiolino
2026-05-27 3:38 ` Yingjie Gao
2026-05-27 3:39 ` [PATCH v2 " Yingjie Gao
2026-05-27 3:39 ` [PATCH v2 1/2] xfs: fix error returns in CoW fork repair Yingjie Gao
2026-05-27 3:39 ` [PATCH v2 2/2] xfs: fix rtgroup cleanup " Yingjie Gao
2026-05-27 4:31 ` [PATCH v3 0/2] xfs: fix CoW fork repair error handling Yingjie Gao
2026-05-27 4:31 ` [PATCH v3 1/2] xfs: fix error returns in CoW fork repair Yingjie Gao
2026-05-28 4:44 ` Darrick J. Wong
2026-05-28 8:08 ` Carlos Maiolino
2026-05-27 4:31 ` [PATCH v3 2/2] xfs: fix rtgroup cleanup " Yingjie Gao
2026-05-28 4:45 ` Darrick J. Wong
2026-05-30 6:40 ` [PATCH v3 0/2] xfs: fix CoW fork repair error handling Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahWzvgOLcXKTLyPq@nidhogg.toxiclabs.cc \
--to=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=gaoyingjie@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®