From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
rodrigo.alencar@analog.com, dlechner@baylibre.com,
jic23@kernel.org
Subject: Re: [PATCH v1 1/2] kstrtox: Make _parse_integer() take variadic arguments
Date: Wed, 3 Jun 2026 09:47:06 +0300 [thread overview]
Message-ID: <ah_N6uuLt9wGDTDW@ashevche-desk.local> (raw)
In-Reply-To: <20260602203706.103449-2-andriy.shevchenko@linux.intel.com>
On Tue, Jun 02, 2026 at 10:29:46PM +0200, Andy Shevchenko wrote:
> Instead of having different functions that just use default parameters,
> combine those to use variadic arguments, so the user may call it using
> the same name.
...
Maybe we also need to add a comment here
/* Do NOT call this directly, use _parse_integer() wrapper instead */
> unsigned int _parse_integer_limit(const char *s, unsigned int base, unsigned long long *res,
> size_t max_chars);
...
Overall I think independently on the new user (if it comes or not) this change
is good on itself. Petr, what do you think about this?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-03 6:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 20:29 [PATCH v1 0/2] kstrtox: make _parse_integer() flexible Andy Shevchenko
2026-06-02 20:29 ` [PATCH v1 1/2] kstrtox: Make _parse_integer() take variadic arguments Andy Shevchenko
2026-06-03 6:47 ` Andy Shevchenko [this message]
2026-06-03 10:37 ` David Laight
2026-06-03 10:54 ` Andy Shevchenko
2026-06-03 10:56 ` Andy Shevchenko
2026-06-03 11:34 ` David Laight
2026-06-02 20:29 ` [PATCH v1 2/2] vsprintf: Convert to use _parse_integer() instead of _parse_integer_limit() Andy Shevchenko
2026-06-03 11:23 ` [PATCH v1 0/2] kstrtox: make _parse_integer() flexible Petr Mladek
2026-06-03 11:51 ` Rodrigo Alencar
2026-06-03 12:10 ` Rodrigo Alencar
2026-06-03 13:58 ` Andy Shevchenko
2026-06-03 13:53 ` Andy Shevchenko
2026-06-04 6:59 ` Petr Mladek
2026-06-04 7:19 ` Andy Shevchenko
2026-06-04 7:48 ` Rodrigo Alencar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah_N6uuLt9wGDTDW@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dlechner@baylibre.com \
--cc=dmantipov@yandex.ru \
--cc=jic23@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rodrigo.alencar@analog.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®