From: Christoph Hellwig <hch@infradead.org>
To: Farhad Alemi <farhad.alemi@berkeley.edu>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] freevxfs: don't BUG() on duplicate OLT entries
Date: Tue, 26 May 2026 23:23:17 -0700 [thread overview]
Message-ID: <ahaN1T700M-yq_EN@infradead.org> (raw)
In-Reply-To: <CA+0ovCi2pCoOijXhCTgfiPQ=B4pPKoTpf5w+akUXwZA-h0NW2Q@mail.gmail.com>
On Tue, May 26, 2026 at 11:49:47AM -0700, Farhad Alemi wrote:
> Hi Christoph,
>
> Thanks for the review. Before sending v2, I tested WARN_ON_ONCE against the
> original reproducer, and on a panic_on_warn=y kernel it still panics (the
> WARN fires and panic_on_warn promotes it).
> Would pr_warn_once() work instead, to keep the diagnostic without the
> panic_on_warn coupling?
That's fine. People who set panic_on_warn=y for anyting but debug
kernels deserve this.
> Happy to respin either way — just thought I'd check before doing so.
Sure, it's always good to ask!
next prev parent reply other threads:[~2026-05-27 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 1:10 Farhad Alemi
2026-05-26 6:40 ` Christoph Hellwig
[not found] ` <CA+0ovCi2pCoOijXhCTgfiPQ=B4pPKoTpf5w+akUXwZA-h0NW2Q@mail.gmail.com>
2026-05-27 6:23 ` Christoph Hellwig [this message]
2026-05-29 21:29 ` [PATCH v2] " Farhad Alemi
2026-06-01 7:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahaN1T700M-yq_EN@infradead.org \
--to=hch@infradead.org \
--cc=farhad.alemi@berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®