mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <ljs@kernel.org>
To: Yi Xie <xieyi@kylinos.cn>
Cc: Christian Brauner <brauner@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipc/sem.c: use unsigned int for nsops
Date: Wed, 27 May 2026 16:54:42 +0100	[thread overview]
Message-ID: <ahcTnZgINRtFMwGb@lucifer> (raw)
In-Reply-To: <20260525004220.19277-1-xieyi@kylinos.cn>

On Mon, May 25, 2026 at 08:42:20AM +0800, Yi Xie wrote:
> Use unsigned int instead of unsigned for nsops parameter,
> to match declaration in syscalls.h.
>
> Signed-off-by: Yi Xie <xieyi@kylinos.cn>

Pretty sure I R-b'd this :P (didn't I?) not sure if too late since Christian
took but FWIW:

Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>

Cheers, Lorenzo

> ---
>  ipc/sem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ipc/sem.c b/ipc/sem.c
> index 6cdf862b1f5c..5ec41de7e85b 100644
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -1981,7 +1981,7 @@ static struct sem_undo *find_alloc_undo(struct ipc_namespace *ns, int semid)
>  }
>
>  long __do_semtimedop(int semid, struct sembuf *sops,
> -		unsigned nsops, const struct timespec64 *timeout,
> +		unsigned int nsops, const struct timespec64 *timeout,
>  		struct ipc_namespace *ns)
>  {
>  	int error = -EINVAL;
> @@ -2220,7 +2220,7 @@ long __do_semtimedop(int semid, struct sembuf *sops,
>  }
>
>  static long do_semtimedop(int semid, struct sembuf __user *tsops,
> -		unsigned nsops, const struct timespec64 *timeout)
> +		unsigned int nsops, const struct timespec64 *timeout)
>  {
>  	struct sembuf fast_sops[SEMOPM_FAST];
>  	struct sembuf *sops = fast_sops;
> @@ -2294,7 +2294,7 @@ SYSCALL_DEFINE4(semtimedop_time32, int, semid, struct sembuf __user *, tsems,
>  #endif
>
>  SYSCALL_DEFINE3(semop, int, semid, struct sembuf __user *, tsops,
> -		unsigned, nsops)
> +		unsigned int, nsops)
>  {
>  	return do_semtimedop(semid, tsops, nsops, NULL);
>  }
> --
> 2.25.1
>

      parent reply	other threads:[~2026-05-27 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  0:42 Yi Xie
2026-05-27 12:10 ` Christian Brauner
2026-05-27 15:54 ` Lorenzo Stoakes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahcTnZgINRtFMwGb@lucifer \
    --to=ljs@kernel.org \
    --cc=brauner@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xieyi@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®