From: Mark Brown <broonie@kernel.org>
To: david@ixit.cz
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH QUESTION] ASoC: qcom: sdm845: use DSP_A format for TDM codec DAIs
Date: Sun, 14 Jun 2026 00:53:13 +0100 [thread overview]
Message-ID: <ai3tafRfEgN938cu@sirena.co.uk> (raw)
In-Reply-To: <20260613-rfc-dsp-b-to-a-v1-1-7d095fe90a05@ixit.cz>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Sat, Jun 13, 2026 at 09:55:59PM +0200, David Heidelberg via B4 Relay wrote:
> Currently this worked only because the cs35l36
> codec mapped both DSP_A and DSP_B to the same hardware register value
> (asp_fmt = 0), which is inherently DSP_A timing.
> The CPU-side AFE is configured with qcom,tdm-data-delay = <1> which
> produces DSP_A framing.
> The codec format should match what is actually on the wire.
> So I'm pretty lost if I should go fixing cs35l36 or sdm845.c.
That sounds like both. The Cirrus driver is definitely buggy if it's
mapping DSP A and B to the same register value, at least one of those is
wrong.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-06-13 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 19:55 David Heidelberg via B4 Relay
2026-06-13 23:53 ` Mark Brown [this message]
2026-06-14 7:26 ` David Heidelberg
2026-06-14 10:35 ` Mark Brown
2026-06-14 21:40 ` Srinivas Kandagatla
2026-06-21 15:54 ` David Heidelberg
2026-06-22 15:18 ` Richard Acayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai3tafRfEgN938cu@sirena.co.uk \
--to=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®