mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH QUESTION] ASoC: qcom: sdm845: use DSP_A format for TDM codec DAIs
Date: Sun, 14 Jun 2026 11:35:52 +0100	[thread overview]
Message-ID: <ai6ECJgLG_GGx3tM@sirena.co.uk> (raw)
In-Reply-To: <5f262a04-8e92-4ac1-bd7c-1246231d3de2@ixit.cz>

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

On Sun, Jun 14, 2026 at 09:26:42AM +0200, David Heidelberg wrote:
> On 14/06/2026 01:53, Mark Brown wrote:

> > That sounds like both.  The Cirrus driver is definitely buggy if it's
> > mapping DSP A and B to the same register value, at least one of those is
> > wrong.

> I need to clarify. The CS35L36 supports by default only DSP_A, but when
> extended to "take DSP_B", speaker just works.

> This was done previously.

No, that's buggy.  If the device only supports DSP A then the device
only support DSP A and the driver should express that.  Any hacks that
can be done to make it interoperate with something else should be done
in the framework.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-06-14 10:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13 19:55 David Heidelberg via B4 Relay
2026-06-13 23:53 ` Mark Brown
2026-06-14  7:26   ` David Heidelberg
2026-06-14 10:35     ` Mark Brown [this message]
2026-06-14 21:40     ` Srinivas Kandagatla
2026-06-21 15:54       ` David Heidelberg
2026-06-22 15:18         ` Richard Acayan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ai6ECJgLG_GGx3tM@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=david@ixit.cz \
    --cc=konradybcio@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®