From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Maxwell Doose <m32285159@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pcmcia: cs: Replace manual mutex locking with guard(mutex)
Date: Thu, 4 Jun 2026 15:40:40 +0200 [thread overview]
Message-ID: <aiGAWELS5T5B2Cfx@shine.dominikbrodowski.net> (raw)
In-Reply-To: <CAKqfh0FK4vcm=5zzOHEZaiPRn_==s-NQof=JM-QFdE3vyKKBjQ@mail.gmail.com>
Am Thu, Jun 04, 2026 at 08:26:59AM -0500 schrieb Maxwell Doose:
> Hi Dominik,
>
> On Thu, Jun 4, 2026 at 1:07 AM Dominik Brodowski
> <linux@dominikbrodowski.net> wrote:
> >
> > Am Wed, Jun 03, 2026 at 01:27:12AM -0500 schrieb Maxwell Doose:
> > > The current code uses manual mutex locking. Replace it with the RAII
> > > guard(mutex) alongside some helpers to help condense some sections and
> > > increase readability.
> >
> > As the PCMCIA subsystem is in "odd fixes" mode, I don't see real advantages
> > for this patch.
> >
>
> Ah. Is that because not enough time or PCMCIA isn't in use much
> anymore? Or something else?
Both. If there are clear improvements (or even security-relevant fixes), I'm
happy to take patches, but otherwise PCMCIA is slowly on its way out.
Best,
Dominik
next prev parent reply other threads:[~2026-06-04 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 6:27 Maxwell Doose
2026-06-03 17:44 ` kernel test robot
2026-06-04 6:05 ` Dominik Brodowski
2026-06-04 13:26 ` Maxwell Doose
2026-06-04 13:40 ` Dominik Brodowski [this message]
2026-06-04 14:21 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiGAWELS5T5B2Cfx@shine.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®