From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Miao Li <limiao870622@163.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, bigeasy@linutronix.de, dixitparmar19@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Miao Li <limiao@kylinos.cn>
Subject: Re: [PATCH v2] iio: accel: stk8ba50: Update includes to match IWYU
Date: Mon, 15 Jun 2026 12:57:20 +0300 [thread overview]
Message-ID: <ai_MgM_5WGs2y8FC@ashevche-desk.local> (raw)
In-Reply-To: <20260615092116.83850-1-limiao870622@163.com>
On Mon, Jun 15, 2026 at 05:21:16PM +0800, Miao Li wrote:
> From: Miao Li <limiao@kylinos.cn>
>
> Update the list of included headers in stk8ba50.c using
> Include-What-You-Use (IWYU) tool, mainly to remove kernel.h
> and add missing headers such as array_size.h, bits.h,
> dev_printk.h, etc.
...
> Changes in v2:
> - Drop linux/iio/types.h as it is already included by linux/iio/iio.h
> - Link to v1:
> https://lore.kernel.org/all/20260603015033.187735-1-limiao870622@163.com/
Put the changelog in the corresponding place...
> Signed-off-by: Miao Li <limiao@kylinos.cn>
> ---
...id est somewhere here. (Basically after '---' cutter line.)
> drivers/iio/accel/stk8ba50.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Code wise looks good to me, feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
after addressing the above issue in the commit message.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-06-15 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 9:21 Miao Li
2026-06-15 9:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai_MgM_5WGs2y8FC@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=limiao870622@163.com \
--cc=limiao@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®