* [PATCH v2] iio: accel: stk8ba50: Update includes to match IWYU
@ 2026-06-15 9:21 Miao Li
2026-06-15 9:57 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Miao Li @ 2026-06-15 9:21 UTC (permalink / raw)
To: jic23
Cc: dlechner, nuno.sa, andy, bigeasy, dixitparmar19, linux-iio,
linux-kernel, limiao870622, Miao Li
From: Miao Li <limiao@kylinos.cn>
Update the list of included headers in stk8ba50.c using
Include-What-You-Use (IWYU) tool, mainly to remove kernel.h
and add missing headers such as array_size.h, bits.h,
dev_printk.h, etc.
Changes in v2:
- Drop linux/iio/types.h as it is already included by linux/iio/iio.h
- Link to v1:
https://lore.kernel.org/all/20260603015033.187735-1-limiao870622@163.com/
Signed-off-by: Miao Li <limiao@kylinos.cn>
---
drivers/iio/accel/stk8ba50.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c
index a9ff2a273fe1..6a60c0fcebe9 100644
--- a/drivers/iio/accel/stk8ba50.c
+++ b/drivers/iio/accel/stk8ba50.c
@@ -7,12 +7,19 @@
* STK8BA50 7-bit I2C address: 0x18.
*/
+#include <linux/array_size.h>
+#include <linux/bits.h>
+#include <linux/dev_printk.h>
+#include <linux/errno.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
-#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/mod_devicetable.h>
+#include <linux/mutex.h>
+#include <linux/pm.h>
+#include <linux/sysfs.h>
#include <linux/types.h>
+
#include <linux/iio/buffer.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iio: accel: stk8ba50: Update includes to match IWYU
2026-06-15 9:21 [PATCH v2] iio: accel: stk8ba50: Update includes to match IWYU Miao Li
@ 2026-06-15 9:57 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-06-15 9:57 UTC (permalink / raw)
To: Miao Li
Cc: jic23, dlechner, nuno.sa, andy, bigeasy, dixitparmar19,
linux-iio, linux-kernel, Miao Li
On Mon, Jun 15, 2026 at 05:21:16PM +0800, Miao Li wrote:
> From: Miao Li <limiao@kylinos.cn>
>
> Update the list of included headers in stk8ba50.c using
> Include-What-You-Use (IWYU) tool, mainly to remove kernel.h
> and add missing headers such as array_size.h, bits.h,
> dev_printk.h, etc.
...
> Changes in v2:
> - Drop linux/iio/types.h as it is already included by linux/iio/iio.h
> - Link to v1:
> https://lore.kernel.org/all/20260603015033.187735-1-limiao870622@163.com/
Put the changelog in the corresponding place...
> Signed-off-by: Miao Li <limiao@kylinos.cn>
> ---
...id est somewhere here. (Basically after '---' cutter line.)
> drivers/iio/accel/stk8ba50.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Code wise looks good to me, feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
after addressing the above issue in the commit message.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-15 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-15 9:21 [PATCH v2] iio: accel: stk8ba50: Update includes to match IWYU Miao Li
2026-06-15 9:57 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®