From: Inochi Amaoto <inochiama@gmail.com>
To: Andrew Rembrandt <kernel@rembrandt.dev>, Yixun Lan <dlan@kernel.org>
Cc: linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: spacemit: k3-pico-itx: Fix non-functional ethernet TX timing
Date: Tue, 9 Jun 2026 13:37:56 +0800 [thread overview]
Message-ID: <aiemGajqcQeY9avz@inochi.infowork> (raw)
In-Reply-To: <20260608182358.170489-1-kernel@rembrandt.dev>
On Mon, Jun 08, 2026 at 08:23:58PM +0200, Andrew Rembrandt wrote:
> The "rgmii-id" PHY mode applies a symmetric 2ns internal delay in the
> PHY. On the Pico-ITX board this leaves insufficient TX timing margin and
> no ethernet traffic passes.
>
> Add a 400ps MAC-side TX internal delay on top of the PHY's delay to
> correct the TX clock/data skew. The value follows the vendor fork's
> asymmetric tuning (tx-phase 73 x 33.3ps - 2000ps ID ~= 400ps); the
> driver rounds tx-internal-delay-ps to the nearest supported step.
>
> This builds on commit 3ea695eb111f ("dts: riscv: spacemit: k3: Fix I/O
> power settings"), which fixed the GMAC0 1.8V/3.3V I/O switch
>
> Tested on Pico-ITX hardware with iperf3: 60s TCP each direction and 60s
> UDP, all at 1Gbps with no TX/RX errors on the interface.
>
> Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
> Signed-off-by: Andrew Rembrandt <kernel@rembrandt.dev>
> ---
> arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index b89c1521e664..59aecaa2d32a 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -186,6 +186,7 @@ ð0 {
> pinctrl-names = "default";
> pinctrl-0 = <&gmac0_rgmii_0_cfg>, <&gmac0_phy_0_cfg>;
> phy-mode = "rgmii-id";
> + tx-internal-delay-ps = <400>;
> phy-handle = <&phy0>;
> status = "okay";
>
You should set tx-internal-delay-ps of the phy instead of
the controller. This is a phy in "rgmii-id" mode.
Regards,
Inochi
next prev parent reply other threads:[~2026-06-09 5:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 18:23 Andrew Rembrandt
2026-06-09 5:37 ` Inochi Amaoto [this message]
2026-06-09 18:24 ` Andrew Rembrandt
2026-06-09 23:14 ` Inochi Amaoto
2026-06-10 9:05 ` Andrew Rembrandt
2026-06-11 7:29 ` E Shattow
2026-07-10 2:25 ` Yixun Lan
2026-07-10 14:34 ` E Shattow
2026-07-18 9:07 ` Andrew Rembrandt
2026-07-19 10:28 ` Yixun Lan
2026-07-19 16:06 ` E Shattow
2026-07-07 7:15 ` Yixun Lan
2026-07-14 9:08 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiemGajqcQeY9avz@inochi.infowork \
--to=inochiama@gmail.com \
--cc=dlan@kernel.org \
--cc=kernel@rembrandt.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®