[PATCH 0/3] media: Media-CI patches for kernel 7.2

[PATCH 0/3] media: Media-CI patches for kernel 7.2

[Ricardo Ribalda]

This series fixes all the media-ci errors for the current linux-next.

They are pretty trivial, so it would be great if we could land them just
after we merge with -rc1, that way we do not need to add more things to
the allowlists.

I have added Fixes: tags for all of them, but feel free to remove them.

Hans, Mauro, please let me know if this is feasible.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Ricardo Ribalda (3):
      media: ov9282: Remove unused kerneldoc description
      media: rzg2l-cru: Remove unused kerneldoc description
      media: mc-entity: Add missing kerneldoc

 drivers/media/i2c/ov9282.c                           | 1 -
 drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
 include/media/media-entity.h                         | 1 +
 3 files changed, 1 insertion(+), 3 deletions(-)
---
base-commit: 06cb687a5132fcffe624c0070576ab852ac6b568
change-id: 20260610-media-ci-7-2-d5835b8ee28d

Best regards,
-- 
Ricardo Ribalda <ribalda@chromium.org>

[PATCH 1/3] media: ov9282: Remove unused kerneldoc description

[Ricardo Ribalda]

The field has been removed, but the kerneldoc not. Let's take care of
this.

This patch fixes the following warning:
Warning: drivers/media/i2c/ov9282.c:223 Excess struct member 'mutex'
description in 'ov9282'

Cc: stable@kernel.org
Fixes: 0c69a963a300 ("media: i2c: ov9282: Switch to using the sub-device state lock")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/i2c/ov9282.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index 5b6f897a74fc..3ba630ec4f2a 100644
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -197,7 +197,6 @@ struct ov9282_mode {
  * @noncontinuous_clock: Selection of CSI2 noncontinuous clock mode
  * @cur_mode: Pointer to current selected sensor mode
  * @code: Mbus code currently selected
- * @mutex: Mutex for serializing sensor controls
  */
 struct ov9282 {
 	struct device *dev;

-- 
2.54.0.1099.g489fc7bff1-goog

Re: [PATCH 1/3] media: ov9282: Remove unused kerneldoc description

[Dan Scally]

Hi Ricardo

On 10/06/2026 17:20, Ricardo Ribalda wrote:
> The field has been removed, but the kerneldoc not. Let's take care of
> this.
> 
> This patch fixes the following warning:
> Warning: drivers/media/i2c/ov9282.c:223 Excess struct member 'mutex'
> description in 'ov9282'
> 
> Cc: stable@kernel.org
> Fixes: 0c69a963a300 ("media: i2c: ov9282: Switch to using the sub-device state lock")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   drivers/media/i2c/ov9282.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> index 5b6f897a74fc..3ba630ec4f2a 100644
> --- a/drivers/media/i2c/ov9282.c
> +++ b/drivers/media/i2c/ov9282.c
> @@ -197,7 +197,6 @@ struct ov9282_mode {
>    * @noncontinuous_clock: Selection of CSI2 noncontinuous clock mode
>    * @cur_mode: Pointer to current selected sensor mode
>    * @code: Mbus code currently selected
> - * @mutex: Mutex for serializing sensor controls
>    */
>   struct ov9282 {
>   	struct device *dev;
> 

Re: [PATCH 1/3] media: ov9282: Remove unused kerneldoc description

[Laurent Pinchart]

On Wed, Jun 10, 2026 at 04:20:06PM +0000, Ricardo Ribalda wrote:
> The field has been removed, but the kerneldoc not. Let's take care of
> this.
> 
> This patch fixes the following warning:
> Warning: drivers/media/i2c/ov9282.c:223 Excess struct member 'mutex'
> description in 'ov9282'
> 
> Cc: stable@kernel.org
> Fixes: 0c69a963a300 ("media: i2c: ov9282: Switch to using the sub-device state lock")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  drivers/media/i2c/ov9282.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> index 5b6f897a74fc..3ba630ec4f2a 100644
> --- a/drivers/media/i2c/ov9282.c
> +++ b/drivers/media/i2c/ov9282.c
> @@ -197,7 +197,6 @@ struct ov9282_mode {
>   * @noncontinuous_clock: Selection of CSI2 noncontinuous clock mode
>   * @cur_mode: Pointer to current selected sensor mode
>   * @code: Mbus code currently selected
> - * @mutex: Mutex for serializing sensor controls
>   */
>  struct ov9282 {
>  	struct device *dev;
> 

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/3] media: ov9282: Remove unused kerneldoc description

[Dave Stevenson]

On Wed, 10 Jun 2026 at 17:20, Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> The field has been removed, but the kerneldoc not. Let's take care of
> this.
>
> This patch fixes the following warning:
> Warning: drivers/media/i2c/ov9282.c:223 Excess struct member 'mutex'
> description in 'ov9282'
>
> Cc: stable@kernel.org
> Fixes: 0c69a963a300 ("media: i2c: ov9282: Switch to using the sub-device state lock")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

Thanks!

> ---
>  drivers/media/i2c/ov9282.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> index 5b6f897a74fc..3ba630ec4f2a 100644
> --- a/drivers/media/i2c/ov9282.c
> +++ b/drivers/media/i2c/ov9282.c
> @@ -197,7 +197,6 @@ struct ov9282_mode {
>   * @noncontinuous_clock: Selection of CSI2 noncontinuous clock mode
>   * @cur_mode: Pointer to current selected sensor mode
>   * @code: Mbus code currently selected
> - * @mutex: Mutex for serializing sensor controls
>   */
>  struct ov9282 {
>         struct device *dev;
>
> --
> 2.54.0.1099.g489fc7bff1-goog
>

[PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Ricardo Ribalda]

The variable has been previously removed but not its kerneldoc.

Also remove the leftover reference to state in the description of qlock.

This patch fixes the following warning:

Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
Excess struct member 'state' description in 'rzg2l_cru_dev'

Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
index 5bf334e173d2..b426bc7898bf 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
@@ -116,11 +116,9 @@ struct rzg2l_cru_info {
  * @scratch_phys:	physical address of the scratch buffer
  *
  * @qlock:		protects @queue_buf, @buf_list, @sequence
- *			@state
  * @queue_buf:		Keeps track of buffers given to HW slot
  * @buf_list:		list of queued buffers
  * @sequence:		V4L2 buffers sequence number
- * @state:		keeps track of operation state
  *
  * @format:		active V4L2 pixel format
  */

-- 
2.54.0.1099.g489fc7bff1-goog

Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Dan Scally]

Hi Ricardo - thanks for the patch

On 10/06/2026 17:20, Ricardo Ribalda wrote:
> The variable has been previously removed but not its kerneldoc.
> 
> Also remove the leftover reference to state in the description of qlock.
> 
> This patch fixes the following warning:
> 
> Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> Excess struct member 'state' description in 'rzg2l_cru_dev'
> 
> Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> index 5bf334e173d2..b426bc7898bf 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
>    * @scratch_phys:	physical address of the scratch buffer
>    *
>    * @qlock:		protects @queue_buf, @buf_list, @sequence
> - *			@state
>    * @queue_buf:		Keeps track of buffers given to HW slot
>    * @buf_list:		list of queued buffers
>    * @sequence:		V4L2 buffers sequence number
> - * @state:		keeps track of operation state
>    *
>    * @format:		active V4L2 pixel format
>    */
> 

Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Jacopo Mondi]

Hi Ricardo

On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> The variable has been previously removed but not its kerneldoc.
>
> Also remove the leftover reference to state in the description of qlock.
>
> This patch fixes the following warning:
>
> Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> Excess struct member 'state' description in 'rzg2l_cru_dev'

upsie

indeed!

>
> Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")

My only question is if this qualifies for stable or not...
Honestly, I would drop the Fixes tag here

> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> index 5bf334e173d2..b426bc7898bf 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
>   * @scratch_phys:	physical address of the scratch buffer
>   *
>   * @qlock:		protects @queue_buf, @buf_list, @sequence
> - *			@state
>   * @queue_buf:		Keeps track of buffers given to HW slot
>   * @buf_list:		list of queued buffers
>   * @sequence:		V4L2 buffers sequence number
> - * @state:		keeps track of operation state
>   *
>   * @format:		active V4L2 pixel format
>   */
>
> --
> 2.54.0.1099.g489fc7bff1-goog
>

Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Ricardo Ribalda]

Hi Jacopo

On Wed, 10 Jun 2026 at 18:30, Jacopo Mondi
<jacopo.mondi@ideasonboard.com> wrote:
>
> Hi Ricardo
>
> On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> > The variable has been previously removed but not its kerneldoc.
> >
> > Also remove the leftover reference to state in the description of qlock.
> >
> > This patch fixes the following warning:
> >
> > Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> > Excess struct member 'state' description in 'rzg2l_cru_dev'
>
> upsie
>
> indeed!
>
> >
> > Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
>
> My only question is if this qualifies for stable or not...
> Honestly, I would drop the Fixes tag here

Yeah, I am not even sure myself

On one hand, it might help other CIs down there have cleaner logs, it
is very low risk, and I doubt that it will have any conflicts.
On the other, what real user will benefit from this backport?

I wrote in the cover that this can be dropped. I'd let more clever
people decide :P

>
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
> > ---
> >  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > index 5bf334e173d2..b426bc7898bf 100644
> > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
> >   * @scratch_phys:    physical address of the scratch buffer
> >   *
> >   * @qlock:           protects @queue_buf, @buf_list, @sequence
> > - *                   @state
> >   * @queue_buf:               Keeps track of buffers given to HW slot
> >   * @buf_list:                list of queued buffers
> >   * @sequence:                V4L2 buffers sequence number
> > - * @state:           keeps track of operation state
> >   *
> >   * @format:          active V4L2 pixel format
> >   */
> >
> > --
> > 2.54.0.1099.g489fc7bff1-goog
> >



-- 
Ricardo Ribalda

Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Jacopo Mondi]

On Wed, Jun 10, 2026 at 06:35:36PM +0200, Ricardo Ribalda wrote:
> Hi Jacopo
>
> On Wed, 10 Jun 2026 at 18:30, Jacopo Mondi
> <jacopo.mondi@ideasonboard.com> wrote:
> >
> > Hi Ricardo
> >
> > On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> > > The variable has been previously removed but not its kerneldoc.
> > >
> > > Also remove the leftover reference to state in the description of qlock.
> > >
> > > This patch fixes the following warning:
> > >
> > > Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> > > Excess struct member 'state' description in 'rzg2l_cru_dev'
> >
> > upsie
> >
> > indeed!
> >
> > >
> > > Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
> >
> > My only question is if this qualifies for stable or not...
> > Honestly, I would drop the Fixes tag here
>
> Yeah, I am not even sure myself
>
> On one hand, it might help other CIs down there have cleaner logs, it
> is very low risk, and I doubt that it will have any conflicts.
> On the other, what real user will benefit from this backport?
>
> I wrote in the cover that this can be dropped. I'd let more clever
> people decide :P
>

From Documentation/process/stable-kernel-rules.rst:

- It must either fix a real bug that bothers people or just add a device ID.
  To elaborate on the former:

  - It fixes a problem like an oops, a hang, data corruption, a real security
    issue, a hardware quirk, a build error (but not for things marked
    CONFIG_BROKEN), or some "oh, that's not good" issue.
  - Serious issues as reported by a user of a distribution kernel may also
    be considered if they fix a notable performance or interactivity issue.
    As these fixes are not as obvious and have a higher risk of a subtle
    regression they should only be submitted by a distribution kernel
    maintainer and include an addendum linking to a bugzilla entry if it
    exists and additional information on the user-visible impact.
  - No "This could be a problem..." type of things like a "theoretical race
    condition", unless an explanation of how the bug can be exploited is also
    provided.
  - No "trivial" fixes without benefit for users (spelling changes, whitespace
    cleanups, etc).

Are Documentation warnings considered "build errors" ?

> >
> > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> >
> > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> >
> > > ---
> > >  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > > index 5bf334e173d2..b426bc7898bf 100644
> > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > > @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
> > >   * @scratch_phys:    physical address of the scratch buffer
> > >   *
> > >   * @qlock:           protects @queue_buf, @buf_list, @sequence
> > > - *                   @state
> > >   * @queue_buf:               Keeps track of buffers given to HW slot
> > >   * @buf_list:                list of queued buffers
> > >   * @sequence:                V4L2 buffers sequence number
> > > - * @state:           keeps track of operation state
> > >   *
> > >   * @format:          active V4L2 pixel format
> > >   */
> > >
> > > --
> > > 2.54.0.1099.g489fc7bff1-goog
> > >
>
>
>
> --
> Ricardo Ribalda

Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Laurent Pinchart]

On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> The variable has been previously removed but not its kerneldoc.
> 
> Also remove the leftover reference to state in the description of qlock.
> 
> This patch fixes the following warning:
> 
> Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> Excess struct member 'state' description in 'rzg2l_cru_dev'
> 
> Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")

Does it mean that this patch was merged without going through CI ? Is
there something we need to improve in the process ?

> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> index 5bf334e173d2..b426bc7898bf 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
>   * @scratch_phys:	physical address of the scratch buffer
>   *
>   * @qlock:		protects @queue_buf, @buf_list, @sequence
> - *			@state
>   * @queue_buf:		Keeps track of buffers given to HW slot
>   * @buf_list:		list of queued buffers
>   * @sequence:		V4L2 buffers sequence number
> - * @state:		keeps track of operation state
>   *
>   * @format:		active V4L2 pixel format
>   */
> 

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Ricardo Ribalda]

Hi Laurent

On Wed, 10 Jun 2026 at 22:21, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> > The variable has been previously removed but not its kerneldoc.
> >
> > Also remove the leftover reference to state in the description of qlock.
> >
> > This patch fixes the following warning:
> >
> > Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> > Excess struct member 'state' description in 'rzg2l_cru_dev'
> >
> > Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
>
> Does it mean that this patch was merged without going through CI ? Is
> there something we need to improve in the process ?

Something has changed in the kenel-doc script. If you run this in
media-commiters/next:
scripts/kernel-doc -none -Wall
drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h

There is no error.


>
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> > ---
> >  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > index 5bf334e173d2..b426bc7898bf 100644
> > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
> >   * @scratch_phys:    physical address of the scratch buffer
> >   *
> >   * @qlock:           protects @queue_buf, @buf_list, @sequence
> > - *                   @state
> >   * @queue_buf:               Keeps track of buffers given to HW slot
> >   * @buf_list:                list of queued buffers
> >   * @sequence:                V4L2 buffers sequence number
> > - * @state:           keeps track of operation state
> >   *
> >   * @format:          active V4L2 pixel format
> >   */
> >
>
> --
> Regards,
>
> Laurent Pinchart



--
Ricardo Ribalda

Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description

[Lad, Prabhakar]

On Wed, Jun 10, 2026 at 5:28 PM Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> The variable has been previously removed but not its kerneldoc.
>
> Also remove the leftover reference to state in the description of qlock.
>
> This patch fixes the following warning:
>
> Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> Excess struct member 'state' description in 'rzg2l_cru_dev'
>
> Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
>  1 file changed, 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> index 5bf334e173d2..b426bc7898bf 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
>   * @scratch_phys:      physical address of the scratch buffer
>   *
>   * @qlock:             protects @queue_buf, @buf_list, @sequence
> - *                     @state
>   * @queue_buf:         Keeps track of buffers given to HW slot
>   * @buf_list:          list of queued buffers
>   * @sequence:          V4L2 buffers sequence number
> - * @state:             keeps track of operation state
>   *
>   * @format:            active V4L2 pixel format
>   */
>
> --
> 2.54.0.1099.g489fc7bff1-goog
>
>

[PATCH 3/3] media: mc-entity: Add missing kerneldoc

[Ricardo Ribalda]

The argument args is not documented, and the latest kernel version
complains about that.

This fixes the following warning:
Warning: include/media/media-entity.h:1394 function parameter 'args'
not described in 'media_entity_call'

Cc: stable@kernel.org
Fixes: 48a7c4bac94d ("[media] docs-rst: improve the kAPI documentation for the mediactl")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 include/media/media-entity.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/media/media-entity.h b/include/media/media-entity.h
index d9b72cd87d52..fa393e840669 100644
--- a/include/media/media-entity.h
+++ b/include/media/media-entity.h
@@ -1387,6 +1387,7 @@ void media_remove_intf_links(struct media_interface *intf);
  * @entity: entity where the @operation will be called
  * @operation: type of the operation. Should be the name of a member of
  *	struct &media_entity_operations.
+ * @args: arguments for the operation.
  *
  * This helper function will check if @operation is not %NULL. On such case,
  * it will issue a call to @operation\(@entity, @args\).

-- 
2.54.0.1099.g489fc7bff1-goog

Re: [PATCH 3/3] media: mc-entity: Add missing kerneldoc

[Dan Scally]

Hi Ricardo

On 10/06/2026 17:20, Ricardo Ribalda wrote:
> The argument args is not documented, and the latest kernel version
> complains about that.
> 
> This fixes the following warning:
> Warning: include/media/media-entity.h:1394 function parameter 'args'
> not described in 'media_entity_call'
> 
> Cc: stable@kernel.org
> Fixes: 48a7c4bac94d ("[media] docs-rst: improve the kAPI documentation for the mediactl")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   include/media/media-entity.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index d9b72cd87d52..fa393e840669 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -1387,6 +1387,7 @@ void media_remove_intf_links(struct media_interface *intf);
>    * @entity: entity where the @operation will be called
>    * @operation: type of the operation. Should be the name of a member of
>    *	struct &media_entity_operations.
> + * @args: arguments for the operation.
>    *
>    * This helper function will check if @operation is not %NULL. On such case,
>    * it will issue a call to @operation\(@entity, @args\).
> 

Re: [PATCH 3/3] media: mc-entity: Add missing kerneldoc

[Laurent Pinchart]

On Wed, Jun 10, 2026 at 04:20:08PM +0000, Ricardo Ribalda wrote:
> The argument args is not documented, and the latest kernel version
> complains about that.
> 
> This fixes the following warning:
> Warning: include/media/media-entity.h:1394 function parameter 'args'
> not described in 'media_entity_call'
> 
> Cc: stable@kernel.org
> Fixes: 48a7c4bac94d ("[media] docs-rst: improve the kAPI documentation for the mediactl")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  include/media/media-entity.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index d9b72cd87d52..fa393e840669 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -1387,6 +1387,7 @@ void media_remove_intf_links(struct media_interface *intf);
>   * @entity: entity where the @operation will be called
>   * @operation: type of the operation. Should be the name of a member of
>   *	struct &media_entity_operations.
> + * @args: arguments for the operation.
>   *
>   * This helper function will check if @operation is not %NULL. On such case,
>   * it will issue a call to @operation\(@entity, @args\).
> 

-- 
Regards,

Laurent Pinchart