From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kaitao Cheng <kaitao.cheng@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org, Muchun Song <muchun.song@linux.dev>,
Kaitao Cheng <chengkaitao@kylinos.cn>
Subject: Re: [PATCH] lib/vsprintf: Make no_hash_pointers take effect early
Date: Thu, 11 Jun 2026 10:20:27 +0300 [thread overview]
Message-ID: <aiphu2M93ao7hzmz@ashevche-desk.local> (raw)
In-Reply-To: <8047d447-8d5e-4b6a-9f58-ff5f8bd66682@linux.dev>
On Thu, Jun 11, 2026 at 02:45:15PM +0800, Kaitao Cheng wrote:
> 在 2026/6/10 22:59, Andy Shevchenko 写道:
> > On Wed, Jun 10, 2026 at 08:45:25PM +0800, Kaitao Cheng wrote:
> >
> >> The no_hash_pointers boot parameter is now handled as an alias for
> >> hash_pointers=never. However, hash_pointers=never only records the
> >> selected mode during early parameter parsing, and no_hash_pointers is
> >> not updated until hash_pointers_finalize() runs later from SLUB init.
> >>
> >> This leaves a window during very early boot where %p output is still
> >> hashed even though the user explicitly requested unhashed pointers with
> >> no_hash_pointers or hash_pointers=never.
> >>
> >> Set no_hash_pointers as soon as the "never" mode is parsed. The later
> >> hash_pointers_finalize() call still keeps the final policy decision in
> >> one place, but explicit requests to disable pointer hashing now take
> >> effect for early boot users too.
> >
> > How is it documented now? And if not documented at all, needs to be.
>
> In Documentation/admin-guide/kernel-parameters.txt, the descriptions of
> both no_hash_pointers and hash_pointers= are already marked as [KNL,EARLY],
> which should match the current semantics.
This detail should be also mentioned in the commit message.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-06-11 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 12:45 Kaitao Cheng
2026-06-10 14:59 ` Andy Shevchenko
2026-06-11 6:45 ` Kaitao Cheng
2026-06-11 7:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiphu2M93ao7hzmz@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=chengkaitao@kylinos.cn \
--cc=kaitao.cheng@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=muchun.song@linux.dev \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®