From: "Ahmed S. Darwish" <darwi@linutronix.de>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] x86/cpu: remove Makefile rule for removed UMC CPU support
Date: Fri, 12 Jun 2026 23:05:42 +0200 [thread overview]
Message-ID: <aix0pp1BiaTK0tet@lx-t490> (raw)
In-Reply-To: <20260610033252.164571-1-enelsonmoore@gmail.com>
On Tue, 09 Jun 2026, Ethan Nelson-Moore wrote:
>
> Support for UMC CPUs was removed in commit 7d328c5de43a ("x86/cpu:
> Remove CPU_SUP_UMC_32 support"), but a Makefile rule for the support
> code remained. Remove it.
>
> Fixes: 7d328c5de43a ("x86/cpu: Remove CPU_SUP_UMC_32 support")
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
There is no need for mentioning the fauly commit twice, once in the log
text and once at the Fixes tag. The latter is sufficient (and required.)
Pretty minor, so:
Reviewed-by: Ahmed S. Darwish <darwi@linutronix.de>
next prev parent reply other threads:[~2026-06-12 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 3:32 Ethan Nelson-Moore
2026-06-12 21:05 ` Ahmed S. Darwish [this message]
2026-07-12 1:30 ` [tip: x86/urgent] x86/cpu: Remove " tip-bot2 for Ethan Nelson-Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aix0pp1BiaTK0tet@lx-t490 \
--to=darwi@linutronix.de \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw@amazon.co.uk \
--cc=enelsonmoore@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox