Re: [PATCH v9] extcon: add support for Samsung S2M series PMIC extcon devices

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

Hello,

On Tue, Jun 16, 2026 at 02:59:41PM +0530, Kaustabh Chakraborty wrote:
> +static const struct platform_device_id s2m_muic_id_table[] = {
> +	{ "s2mu005-muic", S2MU005 },

Please make this:

+	{ .name = "s2mu005-muic", .driver_data = S2MU005 },
	
> +	{ /* sentinel */ },

and drop the trailing , here ...

> +};
> +MODULE_DEVICE_TABLE(platform, s2m_muic_id_table);
> +
> +/*
> + * Device is instantiated through parent MFD device and device matching
> + * is done through platform_device_id.
> + *
> + * However if device's DT node contains proper clock compatible and
> + * driver is built as a module, then the *module* matching will be done
> + * through DT aliases. This requires of_device_id table. In the same
> + * time this will not change the actual *device* matching so do not add
> + * .of_match_table.
> + */
> +static const struct of_device_id s2m_muic_of_match_table[] = {
> +	{
> +		.compatible = "samsung,s2mu005-muic",
> +		.data = (void *)S2MU005,
> +	}, {
> +		/* sentinel */
> +	},

... and here.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]