* [PATCH v3] staging: media: atomisp: anr: move trailing statement to its own line
@ 2026-06-22 18:41 Mani Bharadwaj
2026-06-23 9:26 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Mani Bharadwaj @ 2026-06-22 18:41 UTC (permalink / raw)
To: hansg, mchehab, sakari.ailus, andy, gregkh
Cc: linux-media, linux-kernel, linux-staging, Mani Bharadwaj
Move the return statement in ia_css_anr_dump() to its own line
to fix the following checkpatch error:
ERROR: trailing statements should be on next line
No functional change.
Changes in v3:
- Fix subject prefix: add missing 'media:' subsystem tag
per Media CI bot feedback.
Signed-off-by: Mani Bharadwaj <manibharadwajcr@gmail.com>
---
.../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
index 899d56623..fd50a20ac 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
@@ -36,7 +36,8 @@ ia_css_anr_dump(
const struct sh_css_isp_anr_params *anr,
unsigned int level)
{
- if (!anr) return;
+ if (!anr)
+ return;
ia_css_debug_dtrace(level, "Advance Noise Reduction:\n");
ia_css_debug_dtrace(level, "\t%-32s = %d\n",
"anr_threshold", anr->threshold);
--
2.54.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v3] staging: media: atomisp: anr: move trailing statement to its own line
2026-06-22 18:41 [PATCH v3] staging: media: atomisp: anr: move trailing statement to its own line Mani Bharadwaj
@ 2026-06-23 9:26 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-06-23 9:26 UTC (permalink / raw)
To: Mani Bharadwaj
Cc: hansg, mchehab, sakari.ailus, andy, gregkh, linux-media,
linux-kernel, linux-staging
On Tue, Jun 23, 2026 at 12:11:00AM +0530, Mani Bharadwaj wrote:
> Move the return statement in ia_css_anr_dump() to its own line
> to fix the following checkpatch error:
>
> ERROR: trailing statements should be on next line
>
> No functional change.
>
> Changes in v3:
> - Fix subject prefix: add missing 'media:' subsystem tag
> per Media CI bot feedback.
No. Take your time and read the linux-media mailing list archive for last a few
months in regard to this driver. Only _after_ think about contribution (what to
contribute and how).
...
Also read the process documentation. Do your homework before, please.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-23 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-22 18:41 [PATCH v3] staging: media: atomisp: anr: move trailing statement to its own line Mani Bharadwaj
2026-06-23 9:26 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox