From: Corey Minyard <corey@minyard.net>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: ipmb: validate write message length
Date: Wed, 24 Jun 2026 14:04:50 -0500 [thread overview]
Message-ID: <ajwqUuGNs5oIAi83@mail.minyard.net> (raw)
In-Reply-To: <20260624175353.8592-1-alhouseenyousef@gmail.com>
On Wed, Jun 24, 2026 at 07:53:53PM +0200, Yousef Alhouseen wrote:
> ipmb_write() read message fields before validating the length byte.
>
> A zero or short write can read uninitialized stack bytes.
>
> A length smaller than the SMBus header underflows the block write length.
>
> Require a non-empty buffer and the minimum IPMB request length.
>
> Also require the length byte plus payload before parsing the message.
Yes, this is in my next queue for 7.3.
-corey
>
> Signed-off-by: Yousef Alhouseen <alhouseenyousef@gmail.com>
> ---
> drivers/char/ipmi/ipmb_dev_int.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
> index 2fe1d205c..dd750392c 100644
> --- a/drivers/char/ipmi/ipmb_dev_int.c
> +++ b/drivers/char/ipmi/ipmb_dev_int.c
> @@ -141,13 +141,14 @@ static ssize_t ipmb_write(struct file *file, const char __user *buf,
> u8 msg[MAX_MSG_LEN];
> ssize_t ret;
>
> - if (count > sizeof(msg))
> + if (!count || count > sizeof(msg))
> return -EINVAL;
>
> if (copy_from_user(&msg, buf, count))
> return -EFAULT;
>
> - if (count < msg[0])
> + if (msg[IPMB_MSG_LEN_IDX] < IPMB_REQUEST_LEN_MIN ||
> + count < (size_t)msg[IPMB_MSG_LEN_IDX] + 1)
> return -EINVAL;
>
> rq_sa = GET_7BIT_ADDR(msg[RQ_SA_8BIT_IDX]);
> --
> 2.54.0
>
prev parent reply other threads:[~2026-06-24 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 17:53 Yousef Alhouseen
2026-06-24 19:04 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajwqUuGNs5oIAi83@mail.minyard.net \
--to=corey@minyard.net \
--cc=alhouseenyousef@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®