* [PATCH] Revert "printf: Compile the kunit test with DISABLE_BRANCH_PROFILING DISABLE_BRANCH_PROFILING"
@ 2026-07-07 13:55 Petr Mladek
2026-07-07 15:18 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Petr Mladek @ 2026-07-07 13:55 UTC (permalink / raw)
To: Tamir Duberstein, Andy Shevchenko, Steven Rostedt
Cc: Rasmus Villemoes, Sergey Senozhatsky, arnd, Andrew Morton,
Alexander Lobakin, David Laight, Nathan Chancellor, linux-kernel,
Petr Mladek
This reverts commit 8901ac9d2c7eb8ed7ae5e749bf13ecb3b6062488.
The commit 94bfc7f3b0c7 ("err.h: use __always_inline on all error pointer
helpers") fixes the problem with a dead code elimination by always inlining
IS_ERR() function. It prevents the related linker failures as well.
The workaround with disabling branch profiling is not longer necessary.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Closes: https://lore.kernel.org/r/ah6WDkwO8eYY5f2a@ashevche-desk.local
Signed-off-by: Petr Mladek <pmladek@suse.com>
---
lib/tests/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/tests/Makefile b/lib/tests/Makefile
index 4ead57602eac..db678ccdd8b1 100644
--- a/lib/tests/Makefile
+++ b/lib/tests/Makefile
@@ -41,8 +41,6 @@ obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o
obj-$(CONFIG_MIN_HEAP_KUNIT_TEST) += min_heap_kunit.o
CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare)
obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o
-# GCC < 12.1 can miscompile errptr() test when branch profiling is enabled.
-CFLAGS_printf_kunit.o += -DDISABLE_BRANCH_PROFILING
obj-$(CONFIG_PRINTF_KUNIT_TEST) += printf_kunit.o
obj-$(CONFIG_RANDSTRUCT_KUNIT_TEST) += randstruct_kunit.o
obj-$(CONFIG_SCANF_KUNIT_TEST) += scanf_kunit.o
--
2.54.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "printf: Compile the kunit test with DISABLE_BRANCH_PROFILING DISABLE_BRANCH_PROFILING"
2026-07-07 13:55 [PATCH] Revert "printf: Compile the kunit test with DISABLE_BRANCH_PROFILING DISABLE_BRANCH_PROFILING" Petr Mladek
@ 2026-07-07 15:18 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-07-07 15:18 UTC (permalink / raw)
To: Petr Mladek
Cc: Tamir Duberstein, Steven Rostedt, Rasmus Villemoes,
Sergey Senozhatsky, arnd, Andrew Morton, Alexander Lobakin,
David Laight, Nathan Chancellor, linux-kernel
On Tue, Jul 07, 2026 at 03:55:22PM +0200, Petr Mladek wrote:
> This reverts commit 8901ac9d2c7eb8ed7ae5e749bf13ecb3b6062488.
>
> The commit 94bfc7f3b0c7 ("err.h: use __always_inline on all error pointer
> helpers") fixes the problem with a dead code elimination by always inlining
> IS_ERR() function. It prevents the related linker failures as well.
>
> The workaround with disabling branch profiling is not longer necessary.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-07 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-07 13:55 [PATCH] Revert "printf: Compile the kunit test with DISABLE_BRANCH_PROFILING DISABLE_BRANCH_PROFILING" Petr Mladek
2026-07-07 15:18 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®