[PATCH v1] platform/x86: topstar-laptop: Stop setting acpi_device_name/class()

[PATCH v1] platform/x86: topstar-laptop: Stop setting acpi_device_name/class()

[Rafael J. Wysocki]

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The driver sets acpi_device_name() and acpi_device_class() which are
never read afterward, so make it stop doing that.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

This should have been included in

https://lore.kernel.org/linux-acpi/5135166.31r3eYUQgx@rafael.j.wysocki/

but it was missed.

That doesn't matter though too much because it does not depend on
any patches in that series, so it may as well go alone.

---
 drivers/platform/x86/topstar-laptop.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/platform/x86/topstar-laptop.c
+++ b/drivers/platform/x86/topstar-laptop.c
@@ -299,8 +299,6 @@ static int topstar_acpi_probe(struct pla
 
 	platform_set_drvdata(pdev, topstar);
 
-	strscpy(acpi_device_name(device), "Topstar TPSACPI");
-	strscpy(acpi_device_class(device), TOPSTAR_LAPTOP_CLASS);
 	topstar->device = device;
 
 	err = topstar_acpi_init(topstar);

Re: [PATCH v1] platform/x86: topstar-laptop: Stop setting acpi_device_name/class()

[Andy Shevchenko]

On Fri, Jul 03, 2026 at 02:41:51PM +0200, Rafael J. Wysocki wrote:

> The driver sets acpi_device_name() and acpi_device_class() which are
> never read afterward, so make it stop doing that.
> 
> No intentional functional impact.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] platform/x86: topstar-laptop: Stop setting acpi_device_name/class()

[Ilpo Järvinen]

On Fri, 03 Jul 2026 14:41:51 +0200, Rafael J. Wysocki wrote:

> The driver sets acpi_device_name() and acpi_device_class() which are
> never read afterward, so make it stop doing that.
> 
> No intentional functional impact.

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent or clearly a regression fix.

The list of commits applied:
[1/1] platform/x86: topstar-laptop: Stop setting acpi_device_name/class()
      commit: 51a153f2747fad5dc566f94238b08da07d6a6fb6

--
 i.