* [PATCH] iio: adc: max1241: add missing MODULE_DEVICE_TABLE()
@ 2026-07-04 15:16 Pengpeng Hou
2026-07-04 16:57 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Pengpeng Hou @ 2026-07-04 15:16 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: Pengpeng Hou, linux-iio, linux-kernel
The driver has a match table for the spi bus wired into its driver
structure, but the table is not exported with MODULE_DEVICE_TABLE().
Add the missing MODULE_DEVICE_TABLE() entry so module alias information
is generated for automatic module loading.
This is a source-level fix. It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the driver registration structure, and the missing module alias
publication.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/iio/adc/max1241.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c
index d62c1a011659..cab04beae729 100644
--- a/drivers/iio/adc/max1241.c
+++ b/drivers/iio/adc/max1241.c
@@ -179,6 +179,7 @@ static const struct spi_device_id max1241_id[] = {
{ "max1241", max1241 },
{ }
};
+MODULE_DEVICE_TABLE(spi, max1241_id);
static const struct of_device_id max1241_dt_ids[] = {
{ .compatible = "maxim,max1241" },
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: max1241: add missing MODULE_DEVICE_TABLE()
2026-07-04 15:16 [PATCH] iio: adc: max1241: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
@ 2026-07-04 16:57 ` Andy Shevchenko
2026-07-04 23:58 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-07-04 16:57 UTC (permalink / raw)
To: Pengpeng Hou
Cc: Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel
On Sat, Jul 04, 2026 at 11:16:33PM +0800, Pengpeng Hou wrote:
> The driver has a match table for the spi bus wired into its driver
> structure, but the table is not exported with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> is generated for automatic module loading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the driver registration structure, and the missing module alias
> publication.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: max1241: add missing MODULE_DEVICE_TABLE()
2026-07-04 16:57 ` Andy Shevchenko
@ 2026-07-04 23:58 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2026-07-04 23:58 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Pengpeng Hou, David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel
On Sat, 4 Jul 2026 19:57:37 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sat, Jul 04, 2026 at 11:16:33PM +0800, Pengpeng Hou wrote:
> > The driver has a match table for the spi bus wired into its driver
> > structure, but the table is not exported with MODULE_DEVICE_TABLE().
> >
> > Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> > is generated for automatic module loading.
> >
> > This is a source-level fix. It does not claim dynamic hardware
> > reproduction; the evidence is the driver-owned match table, its use by
> > the driver registration structure, and the missing module alias
> > publication.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
I'm not rushing this in given we don't have reports of it actually
causing problems for any users. Applied to the testing branch of iio.git
which means it'll go upstream in the next merge window
Thanks,
Jonathan
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-04 23:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-04 15:16 [PATCH] iio: adc: max1241: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-04 16:57 ` Andy Shevchenko
2026-07-04 23:58 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®