* [PATCH] extcon: intel-mrfld: Remove redundant dev_err_probe()
@ 2026-07-17 2:17 Pan Chuang
2026-07-17 8:12 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-17 2:17 UTC (permalink / raw)
To: Andy Shevchenko, MyungJoo Ham, Chanwoo Choi,
open list:INTEL MID (Mobile Internet Device) PLATFORM
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/extcon/extcon-intel-mrfld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-intel-mrfld.c b/drivers/extcon/extcon-intel-mrfld.c
index 7246d704fa3d..e23a83796677 100644
--- a/drivers/extcon/extcon-intel-mrfld.c
+++ b/drivers/extcon/extcon-intel-mrfld.c
@@ -223,7 +223,7 @@ static int mrfld_extcon_probe(struct platform_device *pdev)
IRQF_ONESHOT | IRQF_SHARED, pdev->name,
data);
if (ret)
- return dev_err_probe(dev, ret, "can't register IRQ handler\n");
+ return ret;
ret = regmap_read(regmap, BCOVE_ID, &id);
if (ret)
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: intel-mrfld: Remove redundant dev_err_probe()
2026-07-17 2:17 [PATCH] extcon: intel-mrfld: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-17 8:12 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-07-17 8:12 UTC (permalink / raw)
To: Pan Chuang
Cc: Andy Shevchenko, MyungJoo Ham, Chanwoo Choi,
open list:INTEL MID (Mobile Internet Device) PLATFORM
On Fri, Jul 17, 2026 at 10:17:21AM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err_probe() calls.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-17 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-17 2:17 [PATCH] extcon: intel-mrfld: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 8:12 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®