mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, frederic@kernel.org,
	jstultz@google.com, juri.lelli@redhat.com, mingo@redhat.com,
	peterz@infradead.org, tglx@linutronix.de,
	vincent.guittot@linaro.org, vschneid@redhat.com
Subject: Re: [PATCH 1/5] sched: dynamic: Make PREEMPT_DYNAMIC depend on ARCH_HAS_PREEMPT_LAZY
Date: Fri, 17 Jul 2026 11:59:13 +0100	[thread overview]
Message-ID: <aloLAbF1POaEIUE7@J2N7QTR9R3> (raw)
In-Reply-To: <860baba7-e65d-463b-85cc-feb9c4f930c7@linux.ibm.com>

On Mon, Jul 06, 2026 at 10:06:29AM +0530, Shrikanth Hegde wrote:
> On 7/3/26 7:03 PM, Mark Rutland wrote:
> > On architectures which select ARCH_HAS_PREEMPT_LAZY, it has not been
> > possible to select the NONE and VOLUNTARY preemption models since
> > commit:
> > 
> >    7dadeaa6e851 ("sched: Further restrict the preemption modes")
> > 
> > ... which was merged in v7.0.
> > 
> > All architectures which currently suppoort PREEMPT_DYNAMIC select
> 
> s/suppoort/support

Thanks; fixed locally now.

[...]

> > diff --git a/kernel/Kconfig.preempt b/kernel/Kconfig.preempt
> > index 88c594c6d7fcd..fb49424003b2b 100644
> > --- a/kernel/Kconfig.preempt
> > +++ b/kernel/Kconfig.preempt
> > @@ -129,6 +129,7 @@ config PREEMPTION
> >   config PREEMPT_DYNAMIC
> >   	bool "Preemption behaviour defined on boot"
> >   	depends on HAVE_PREEMPT_DYNAMIC
> > +	depends on ARCH_HAS_PREEMPT_LAZY
> >   	select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY
> >   	select PREEMPT_BUILD
> >   	default y if HAVE_PREEMPT_DYNAMIC_CALL
> 
> 
> Can we update the help section bit?
> 
> """
>           The runtime overhead is negligible.
> 
>           Interesting if you want the same pre-built kernel should be used for
>           both Server and Desktop workloads.
> """
> I think server meant preempt=none and desktop meant preempt=full/lazy there. No?

I think that's the common case, yes.

I think the existing wording isn't wrong, so I'm going to leave it as-is
for now, given the wording change is logically separate from the other
changes.

[...]

> other than that, it looks good to me.
> 
> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>

Thanks!

Mark.

  reply	other threads:[~2026-07-17 10:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 13:33 [PATCH 0/5] sched: dynamic: Simplify PREEMPT_DYNAMIC Mark Rutland
2026-07-03 13:33 ` [PATCH 1/5] sched: dynamic: Make PREEMPT_DYNAMIC depend on ARCH_HAS_PREEMPT_LAZY Mark Rutland
2026-07-06  4:36   ` Shrikanth Hegde
2026-07-17 10:59     ` Mark Rutland [this message]
2026-07-27 12:37   ` Jinjie Ruan
2026-07-03 13:33 ` [PATCH 2/5] sched: dynamic: Simplify {cond,might}_resched() Mark Rutland
2026-07-06  4:59   ` Shrikanth Hegde
2026-07-17 11:03     ` Mark Rutland
2026-07-03 13:33 ` [PATCH 3/5] sched: dynamic: Simplify preempt_schedule{,_notrace}() Mark Rutland
2026-07-06  5:19   ` Shrikanth Hegde
2026-07-03 13:33 ` [PATCH 4/5] sched: dynamic: Simplify irqentry_exit_cond_resched() Mark Rutland
2026-07-06  4:42   ` Shrikanth Hegde
2026-07-17 11:05     ` Mark Rutland
2026-07-17 13:49       ` Shrikanth Hegde
2026-07-17 13:57         ` Mark Rutland
2026-07-27 11:28       ` Christophe Leroy (CS GROUP)
2026-07-03 13:33 ` [PATCH 5/5] sched: dynamic: Remove HAVE_PREEMPT_DYNAMIC_{CALL,KEY} Mark Rutland
2026-07-06  4:30 ` [PATCH 0/5] sched: dynamic: Simplify PREEMPT_DYNAMIC Shrikanth Hegde
2026-07-17 11:35   ` Mark Rutland
2026-07-30 15:39 ` Mete Durlu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aloLAbF1POaEIUE7@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=frederic@kernel.org \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sshegde@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®