[PATCH v1] clk: Use named initializers for platform_device_id arrays

[PATCH v1] clk: Use named initializers for platform_device_id arrays

[Uwe Kleine-König (The Capable Hub)]

Named initializers are better readable and more robust to changes of the
struct definition. This robustness is relevant for a planned change to
struct platform_device_id replacing .driver_data by an anonymous union.

While touching these arrays unify spacing and usage of commas.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,

see e.g.
https://lore.kernel.org/all/cover.1779893336.git.u.kleine-koenig@baylibre.com/
for details about my quest to modify platform_device_id.

Best regards
Uwe

 drivers/clk/clk-bd718x7.c      | 12 ++++++------
 drivers/clk/clk-max77686.c     |  8 ++++----
 drivers/clk/clk-s2mps11.c      | 12 ++++++------
 drivers/clk/samsung/clk-acpm.c |  4 ++--
 4 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c
index 1cae974e6d1d..8ddb50c67757 100644
--- a/drivers/clk/clk-bd718x7.c
+++ b/drivers/clk/clk-bd718x7.c
@@ -147,12 +147,12 @@ static int bd71837_clk_probe(struct platform_device *pdev)
 }
 
 static const struct platform_device_id bd718x7_clk_id[] = {
-	{ "bd71837-clk", ROHM_CHIP_TYPE_BD71837 },
-	{ "bd71847-clk", ROHM_CHIP_TYPE_BD71847 },
-	{ "bd71828-clk", ROHM_CHIP_TYPE_BD71828 },
-	{ "bd71815-clk", ROHM_CHIP_TYPE_BD71815 },
-	{ "bd72720-clk", ROHM_CHIP_TYPE_BD72720 },
-	{ },
+	{ .name = "bd71837-clk", .driver_data = ROHM_CHIP_TYPE_BD71837 },
+	{ .name = "bd71847-clk", .driver_data = ROHM_CHIP_TYPE_BD71847 },
+	{ .name = "bd71828-clk", .driver_data = ROHM_CHIP_TYPE_BD71828 },
+	{ .name = "bd71815-clk", .driver_data = ROHM_CHIP_TYPE_BD71815 },
+	{ .name = "bd72720-clk", .driver_data = ROHM_CHIP_TYPE_BD72720 },
+	{ }
 };
 MODULE_DEVICE_TABLE(platform, bd718x7_clk_id);
 
diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
index 9149ce4f702d..e6fde914c5ef 100644
--- a/drivers/clk/clk-max77686.c
+++ b/drivers/clk/clk-max77686.c
@@ -264,10 +264,10 @@ static int max77686_clk_probe(struct platform_device *pdev)
 }
 
 static const struct platform_device_id max77686_clk_id[] = {
-	{ "max77686-clk", .driver_data = CHIP_MAX77686, },
-	{ "max77802-clk", .driver_data = CHIP_MAX77802, },
-	{ "max77620-clock", .driver_data = CHIP_MAX77620, },
-	{},
+	{ .name = "max77686-clk", .driver_data = CHIP_MAX77686 },
+	{ .name = "max77802-clk", .driver_data = CHIP_MAX77802 },
+	{ .name = "max77620-clock", .driver_data = CHIP_MAX77620 },
+	{ }
 };
 MODULE_DEVICE_TABLE(platform, max77686_clk_id);
 
diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c
index ff7ce12a5da6..fa5ac8f673f6 100644
--- a/drivers/clk/clk-s2mps11.c
+++ b/drivers/clk/clk-s2mps11.c
@@ -225,12 +225,12 @@ static void s2mps11_clk_remove(struct platform_device *pdev)
 }
 
 static const struct platform_device_id s2mps11_clk_id[] = {
-	{ "s2mpg10-clk", S2MPG10},
-	{ "s2mps11-clk", S2MPS11X},
-	{ "s2mps13-clk", S2MPS13X},
-	{ "s2mps14-clk", S2MPS14X},
-	{ "s5m8767-clk", S5M8767X},
-	{ },
+	{ .name = "s2mpg10-clk", .driver_data = S2MPG10 },
+	{ .name = "s2mps11-clk", .driver_data = S2MPS11X },
+	{ .name = "s2mps13-clk", .driver_data = S2MPS13X },
+	{ .name = "s2mps14-clk", .driver_data = S2MPS14X },
+	{ .name = "s5m8767-clk", .driver_data = S5M8767X },
+	{ }
 };
 MODULE_DEVICE_TABLE(platform, s2mps11_clk_id);
 
diff --git a/drivers/clk/samsung/clk-acpm.c b/drivers/clk/samsung/clk-acpm.c
index 953ca8d5720a..25cfa953ccac 100644
--- a/drivers/clk/samsung/clk-acpm.c
+++ b/drivers/clk/samsung/clk-acpm.c
@@ -166,8 +166,8 @@ static int acpm_clk_probe(struct platform_device *pdev)
 }
 
 static const struct platform_device_id acpm_clk_id[] = {
-	{ "gs101-acpm-clk" },
-	{}
+	{ .name = "gs101-acpm-clk" },
+	{ }
 };
 MODULE_DEVICE_TABLE(platform, acpm_clk_id);
 

base-commit: e7d700e14934e68f86338c5610cf2ae76798b663
-- 
2.47.3

Re: [PATCH v1] clk: Use named initializers for platform_device_id arrays

[Tudor Ambarus]

Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>

Re: [PATCH v1] clk: Use named initializers for platform_device_id arrays

[Peter Griffin]

On Thu, 28 May 2026 at 11:34, Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@baylibre.com> wrote:
>
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
>
> While touching these arrays unify spacing and usage of commas.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---

Reviewed-by: Peter Griffin <peter.griffin@linaro.org>

Re: [PATCH v1] clk: Use named initializers for platform_device_id arrays

[Brian Masney]

On Thu, May 28, 2026 at 12:29:38PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
> 
> While touching these arrays unify spacing and usage of commas.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Reviewed-by: Brian Masney <bmasney@redhat.com>

Re: [PATCH v1] clk: Use named initializers for platform_device_id arrays

[Matti Vaittinen]

On 28/05/2026 13:29, Uwe Kleine-König (The Capable Hub) wrote:
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
> 
> While touching these arrays unify spacing and usage of commas.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

-- 
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Re: [PATCH v1] clk: Use named initializers for platform_device_id arrays

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Hello,

On Thu, May 28, 2026 at 12:29:38PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
> 
> While touching these arrays unify spacing and usage of commas.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

This patch still applies to next-20260716 and still is complete (i.e. no
new clk drivers appeared that require this type of adaption).

The patch sits in my queue for quite a while now, got positive feedback
only and already missed one merge window.

Do you still have it on your radar?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1] clk: Use named initializers for platform_device_id arrays

[Brian Masney]

Hi Uwe,

On Fri, Jul 17, 2026 at 11:51:17AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> On Thu, May 28, 2026 at 12:29:38PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > Named initializers are better readable and more robust to changes of the
> > struct definition. This robustness is relevant for a planned change to
> > struct platform_device_id replacing .driver_data by an anonymous union.
> > 
> > While touching these arrays unify spacing and usage of commas.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> This patch still applies to next-20260716 and still is complete (i.e. no
> new clk drivers appeared that require this type of adaption).
> 
> The patch sits in my queue for quite a while now, got positive feedback
> only and already missed one merge window.
> 
> Do you still have it on your radar?

I sent Stephen a pull on June 29th for stuff that I felt was missed during
the last merge window and I included 4 of your patches in that pull:

https://lore.kernel.org/linux-clk/akLzCVzbMbUsgDda@redhat.com/T/#u

I haven't heard from Stephen yet. There's 2-3 other pulls waiting as
well.

Brian

clk maintenance [Was: Re: [PATCH v1] clk: Use named initializers for platform_device_id arrays]

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

Hello Brian, Michael and Stephen,

[I trimmed recipients as the new topic isn't related only to my patch
under discussion in this thread.]

On Fri, Jul 17, 2026 at 10:57:54AM -0400, Brian Masney wrote:
> On Fri, Jul 17, 2026 at 11:51:17AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > Do you still have it on your radar?
> 
> I sent Stephen a pull on June 29th for stuff that I felt was missed during
> the last merge window and I included 4 of your patches in that pull:
> 
> https://lore.kernel.org/linux-clk/akLzCVzbMbUsgDda@redhat.com/T/#u
> 
> I haven't heard from Stephen yet. There's 2-3 other pulls waiting as
> well.

I only occasionally have clk patches, but my impression is that getting
feedback takes quite long and without Brian's efforts also things would
get lost. (Thanks Brian for picking up my stuff!)

Looking at the current maintainers:

	$ git log --format=fuller --since 2026-01-01 next-20260717 drivers/clk | grep -E 'Boyd|Turquette' | sort | uniq -c
	      8     Acked-by: Stephen Boyd <sboyd@kernel.org>
	     28 Author:     Stephen Boyd <sboyd@kernel.org>
	      3     Cc: Michael Turquette <mturquette@baylibre.com>
	      3     Cc: Stephen Boyd <sboyd@kernel.org>
	     81 Commit:     Stephen Boyd <sboyd@kernel.org>
	      1     Pull clk fix from Stephen Boyd:
	      3     Pull clk updates from Stephen Boyd:
	     54     Signed-off-by: Stephen Boyd <sboyd@kernel.org>
	linux$ git log --format=oneline --since 2026-01-01 next-20260717 drivers/clk | wc -l
	453

(Maybe that is because Stephen cares for the core mostly and arch
maintainers merge stuff about their clks themselves?)

The last commit where Michael Turquette was actively involved is from
2021 (a331659e32718b31f3a304d7797a77d31610468c) which is also the last
mail from him on the clk list (see
https://lore.kernel.org/linux-clk/?q=f%3ATurquette).

I only observe from the side line, but with the relevance of the clk
subsystem I feel maintenance is underpowered today.

Is it time for Michael to step down? Would Brian be ready to become a
full maintainer? Is there a need for more reviewers? Any volunteers to
step up?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]