mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Extract common MODULE_INFO content into new moduleinfo.h.
Date: Sun, 20 May 2007 01:47:42 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.0.99.0705200142080.25601@chino.kir.corp.google.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705200354380.3319@localhost.localdomain>

On Sun, 20 May 2007, Robert P. J. Day wrote:

> diff --git a/include/linux/moduleinfo.h b/include/linux/moduleinfo.h
> new file mode 100644
> index 0000000..cee86a9
> --- /dev/null
> +++ b/include/linux/moduleinfo.h
> @@ -0,0 +1,18 @@
> +#ifndef _LINUX_MODULEINFO_H
> +#define _LINUX_MODULEINFO_H
> +
> +#ifdef MODULE
> +#include <linux/stringify.h>
> +#define ___module_cat(a,b) __mod_ ## a ## b
> +#define __module_cat(a,b) ___module_cat(a,b)
> +#define __MODULE_INFO(tag, name, info)				\
> +static const char __module_cat(name,__LINE__)[]			\
> +  __attribute_used__						\
> +  __attribute__((section(".modinfo"),unused)) = __stringify(tag) "=" info

This isn't a function definition so __attribute_used__ (which is 
deprecated anyway) doesn't mean anything.  Please simply use 
__maybe_unused and remove "unused" from the second attribute.

  reply	other threads:[~2007-05-20  8:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20  7:57 Robert P. J. Day
2007-05-20  8:47 ` David Rientjes [this message]
2007-05-20 10:28   ` Robert P. J. Day
2007-05-20 16:38     ` David Rientjes
2007-05-20 17:15       ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.0.99.0705200142080.25601@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®