From: David Rientjes <rientjes@google.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Extract common MODULE_INFO content into new moduleinfo.h.
Date: Sun, 20 May 2007 09:38:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.0.99.0705200934580.30819@chino.kir.corp.google.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705200627220.6765@localhost.localdomain>
On Sun, 20 May 2007, Robert P. J. Day wrote:
> i can do that as long as there's no way that those changes can (even
> theoretically) make a difference in the build. in order to make sure
> this patch didn't break anything, i went with a straight cut-and-paste
> of the content to go into the new moduleinfo.h.
>
__attribute_used__ is pointless outside of function definitions so the way
it is currently written is incorrect.
> so while i agree that those changes shouldn't hurt, personally, i'd
> prefer to just put this patch through as is and come back later to do
> any tidying related to attribute rewording.
>
__attribute_used__ is deprecated so it would be helpful to change it now
instead of requiring a second patch. It's better if new patches no longer
use a deprecated attribute.
next prev parent reply other threads:[~2007-05-20 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-20 7:57 Robert P. J. Day
2007-05-20 8:47 ` David Rientjes
2007-05-20 10:28 ` Robert P. J. Day
2007-05-20 16:38 ` David Rientjes [this message]
2007-05-20 17:15 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.0.99.0705200934580.30819@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®