mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Pekka Paalanen <pq@iki.fi>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 -tip 3/4] Tracing/ftrace: Adapt mmiotrace to the new type of print_line
Date: Tue, 30 Sep 2008 08:45:52 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.1.10.0809300844270.1984@gandalf.stny.rr.com> (raw)
In-Reply-To: <c62985530809300539o2842c14fk16708abaf69c4e2f@mail.gmail.com>



On Tue, 30 Sep 2008, Fr?d?ric Weisbecker wrote:
> 
> Thanks Ingo.
> 
> I'm currently testing tip/master, since tracing/pipe is merged into.
> It seems there are some locking issues that I hadn't when I tested the patches.
> Perhaps it's because of the merge with the new ring buffer.
> 
> I just launched the sched_switch tracer and it worked well until 4
> seconds of execution. And after that it blocked.
> I tested too a marker message adding and it is never displayed. Worse:
> I can't break the pipe with Ctrl + C after that.
> 
> When I will have some time, I will try to debug all what I find.
> 

OK, I'll nuke the ring_buffer_lock :-/

The trace_pipe calls that and then calls print_trace_line which will 
eventually lock the buffer again. This is a bug on my part. I'll fix that 
today.

Thanks,

-- Steve


  reply	other threads:[~2008-09-30 12:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29 18:27 Frederic Weisbecker
2008-09-29 19:19 ` Pekka Paalanen
2008-09-30  8:52   ` Ingo Molnar
2008-09-30 12:39     ` Frédéric Weisbecker
2008-09-30 12:45       ` Steven Rostedt [this message]
2008-09-30 13:25         ` Frédéric Weisbecker
2008-09-30 13:33           ` Steven Rostedt
2008-09-30 15:39           ` Ingo Molnar
2008-09-30 16:13             ` Frederic Weisbecker
2008-09-30 16:16               ` Frédéric Weisbecker
2008-10-01  8:06               ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.0809300844270.1984@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pq@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®