mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Pekka Paalanen" <pq@iki.fi>,
	linux-kernel@vger.kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH V2 -tip 3/4] Tracing/ftrace: Adapt mmiotrace to the new type of print_line
Date: Tue, 30 Sep 2008 14:39:06 +0200	[thread overview]
Message-ID: <c62985530809300539o2842c14fk16708abaf69c4e2f@mail.gmail.com> (raw)
In-Reply-To: <20080930085241.GB10374@elte.hu>

2008/9/30 Ingo Molnar <mingo@elte.hu>:
> thanks guys!
>
> Steve's latest trace-ringbuffer code against -tip complicates life a
> little bit.
>
> We dont yet know whether tip/tracing/ring-buffer is ready for wider
> consumption, so it's in a separate feature branch. These four patches
> conflict with the ring-buffer code quite widely.
>
> So ... i did an optimistic merge approach: i merged these 4 patches
> ontop of the new tip/tracing/ring-buffer code, and have put it into a
> new tip/tracing/pipe branch:
>
>  # f19d495: tracing/ftrace: adapt the boot tracer to the new print_line type
>  # 92261f6: tracing/ftrace: adapt mmiotrace to the new type of print_line
>  # 157190e: tracing/ftrace: fix pipe breaking
>  # 92e359a: tracing/ftrace: change the type of the print_line callback
>
> i'm merging this into tip/master for a bit of testing, but if it breaks
> something (or if i havent pushed it out yet) you can merge it locally
> too, by doing this ontop of tip/master:
>
>  git-merge tip/tracing/pipe
>
> it should merge up cleanly and you should be able to check the end
> result. (and send me any fixes for merge mistakes)
>
> ( Once it's all in reasonably well-tested shape it will all show up in
>  tip/master and you can stop dealing with tip/tracing/* sub-branches.)
>
>        Ingo
>

Thanks Ingo.

I'm currently testing tip/master, since tracing/pipe is merged into.
It seems there are some locking issues that I hadn't when I tested the patches.
Perhaps it's because of the merge with the new ring buffer.

I just launched the sched_switch tracer and it worked well until 4
seconds of execution. And after that it blocked.
I tested too a marker message adding and it is never displayed. Worse:
I can't break the pipe with Ctrl + C after that.

When I will have some time, I will try to debug all what I find.

  reply	other threads:[~2008-09-30 12:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29 18:27 Frederic Weisbecker
2008-09-29 19:19 ` Pekka Paalanen
2008-09-30  8:52   ` Ingo Molnar
2008-09-30 12:39     ` Frédéric Weisbecker [this message]
2008-09-30 12:45       ` Steven Rostedt
2008-09-30 13:25         ` Frédéric Weisbecker
2008-09-30 13:33           ` Steven Rostedt
2008-09-30 15:39           ` Ingo Molnar
2008-09-30 16:13             ` Frederic Weisbecker
2008-09-30 16:16               ` Frédéric Weisbecker
2008-10-01  8:06               ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530809300539o2842c14fk16708abaf69c4e2f@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pq@iki.fi \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®