Re: [patch 1/2] timerfd add flags check

[Davide Libenzi <davidel@xmailserver.org>]

On Mon, 9 Feb 2009, Michael Kerrisk wrote:

> On Mon, Feb 9, 2009 at 12:23 PM, Davide Libenzi <davidel@xmailserver.org> wrote:
> > Like Michael requested, this patch adds a missing check for valid flags in
> > timerfd_settime(), and make it return EINVAL in case some extra bits are
> > set. If this is or not a -stable thing, it Greg decision.
> > Should be queued by Andrew for .30, unless -stable and Linus decide to
> > get it before, like Michael suggested.
> 
> When these two patches are applied against .29-rc3:
> 
> $ make
> [...]
>   CC      fs/timerfd.o
> fs/timerfd.c: In function 'sys_timerfd_create':
> fs/timerfd.c:190: error: implicit declaration of function 'invalid_clockid'
> make[1]: *** [fs/timerfd.o] Error 1
> make: *** [fs] Error 2

Yeah, I missed the posix-timers.h inclusion in timerfd.c, when I split the 
first patch into two separate ones. Will re-send tomorrow.


- Davide