mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Kerrisk <mtk.manpages@googlemail.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>, Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 1/2] timerfd add flags check
Date: Mon, 9 Feb 2009 15:34:11 +1300	[thread overview]
Message-ID: <cfd18e0f0902081834l55142925i1f2f068e4aa9b145@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0902081504380.18839@alien.or.mcafeemobile.com>

On Mon, Feb 9, 2009 at 12:23 PM, Davide Libenzi <davidel@xmailserver.org> wrote:
> Like Michael requested, this patch adds a missing check for valid flags in
> timerfd_settime(), and make it return EINVAL in case some extra bits are
> set. If this is or not a -stable thing, it Greg decision.
> Should be queued by Andrew for .30, unless -stable and Linus decide to
> get it before, like Michael suggested.

When these two patches are applied against .29-rc3:

$ make
[...]
  CC      fs/timerfd.o
fs/timerfd.c: In function 'sys_timerfd_create':
fs/timerfd.c:190: error: implicit declaration of function 'invalid_clockid'
make[1]: *** [fs/timerfd.o] Error 1
make: *** [fs] Error 2


Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html

  parent reply	other threads:[~2009-02-09  2:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08 23:23 Davide Libenzi
2009-02-08 23:38 ` Michael Kerrisk
2009-02-09  2:34 ` Michael Kerrisk [this message]
2009-02-09  2:38   ` Davide Libenzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfd18e0f0902081834l55142925i1f2f068e4aa9b145@mail.gmail.com \
    --to=mtk.manpages@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davidel@xmailserver.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®