[PATCH] Quirk for reboot stalls on a Dell Optiplex 330

[PATCH] Quirk for reboot stalls on a Dell Optiplex 330

[Steve Conklin]

>From 6269c416487b41576107ef6f535639d3177daa43 Mon Sep 17 00:00:00 2001
From: Leann Ogasawara <leann.ogasawara@canonical.com>
Date: Wed, 12 Nov 2008 17:01:54 -0600
Subject: [PATCH] Quirk for reboot stalls on a Dell Optiplex 330

Dell Optiplex 330 appears to hang on reboot. This is resolved by adding
a quirk to set bios reboot.

Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
Signed-off-by: Steve Conklin <steve.conklin@canonical.com>
---
 arch/x86/kernel/reboot.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 904a8ea..0d897f8 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -169,6 +169,15 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "0KW626"),
 		},
 	},
+	{   /* Handle problems with rebooting on Dell Optiplex 330 with 0KP561 */
+		.callback = set_bios_reboot,
+		.ident = "Dell OptiPlex 330",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 330"),
+			DMI_MATCH(DMI_BOARD_NAME, "0KP561"),
+		},
+	},
 	{	/* Handle problems with rebooting on Dell 2400's */
 		.callback = set_bios_reboot,
 		.ident = "Dell PowerEdge 2400",
-- 
1.5.6.3

Re: [PATCH] Quirk for reboot stalls on a Dell Optiplex 330

[Ingo Molnar]

* Steve Conklin <sconklin@canonical.com> wrote:

> >From 6269c416487b41576107ef6f535639d3177daa43 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara <leann.ogasawara@canonical.com>
> Date: Wed, 12 Nov 2008 17:01:54 -0600
> Subject: [PATCH] Quirk for reboot stalls on a Dell Optiplex 330
> 
> Dell Optiplex 330 appears to hang on reboot. This is resolved by adding
> a quirk to set bios reboot.
> 
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> Signed-off-by: Steve Conklin <steve.conklin@canonical.com>
> ---
>  arch/x86/kernel/reboot.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)

applied to tip/x86/quirks, thanks Steve!

> +	{   /* Handle problems with rebooting on Dell Optiplex 330 with 0KP561 */
> +		.callback = set_bios_reboot,
> +		.ident = "Dell OptiPlex 330",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 330"),
> +			DMI_MATCH(DMI_BOARD_NAME, "0KP561"),

is the board filter really necessary? It might unnecessarily filter 
out small variations in board names.

	Ingo