mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch] trivial: unreached code. drivers/net/mlx4/en_rx.c
@ 2009-04-08 11:09 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2009-04-08 11:09 UTC (permalink / raw)
  To: linux-kernel

Remove the return after the goto.  We want the goto because it frees 
memory as well as returning err.

Found by smatch (http://repo.or.cz/w/smatch.git).

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>

--- orig/drivers/net/mlx4/en_rx.c	2009-04-07 21:01:20.000000000 +0300
+++ devel/drivers/net/mlx4/en_rx.c	2009-04-07 21:01:27.000000000 +0300
@@ -950,7 +950,6 @@
 	if (err) {
 		mlx4_err(mdev, "Failed to allocate qp #%d\n", qpn);
 		goto out;
-		return err;
 	}
 	qp->event = mlx4_en_sqp_event;
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-08 11:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-08 11:09 [patch] trivial: unreached code. drivers/net/mlx4/en_rx.c Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®