* mISDN: potential null dereference in dsp_cmx_send_member()
@ 2009-08-07 12:13 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2009-08-07 12:13 UTC (permalink / raw)
To: isdn; +Cc: linux-kernel
Hello,
I am testing a source analysis tool (http://repo.or.cz/w/smatch.git)
and it generates a warning in dsp_cmx_send_member().
The problem is that on line 1327 we verify that dsp->conf is non null but
on line 1329 we assume that it is non null and dereference it without
checking.
drivers/isdn/mISDN/dsp_cmx.c
1327 if (dsp->conf && dsp->conf->software && dsp->conf->hardware)
1328 tx_data_only = 1;
1329 if (dsp->conf->software && dsp->echo.hardware)
1330 tx_data_only = 1;
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-08-07 12:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-07 12:13 mISDN: potential null dereference in dsp_cmx_send_member() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®