* checkpatch: EXPORT_SYMBOL() false positive
@ 2010-01-08 19:23 Geert Uytterhoeven
0 siblings, 0 replies; only message in thread
From: Geert Uytterhoeven @ 2010-01-08 19:23 UTC (permalink / raw)
To: Andy Whitcroft; +Cc: Linux Kernel Development, Finn Thain
Hi Andy,
A patch from Finn causes a false positive in checkpatch:
| WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
| #13: FILE: arch/m68k/mac/config.c:801:
| +EXPORT_SYMBOL(scc_a_pdev);
Test case from the patch:
--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -792,6 +792,32 @@ static struct mac_model mac_data_table[] = {
}
};
+struct platform_device scc_a_pdev = {
+ .name = "scc",
+ .id = 0,
+ .num_resources = ARRAY_SIZE(scc_a_rsrcs),
+ .resource = scc_a_rsrcs,
+};
+EXPORT_SYMBOL(scc_a_pdev);
+
static void __init mac_identify(void)
{
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-08 19:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-08 19:23 checkpatch: EXPORT_SYMBOL() false positive Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®