From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jeremy@goop.org" <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"ddutile@redhat.com" <ddutile@redhat.com>,
"sheng@linux.intel.com" <sheng@linux.intel.com>
Subject: Re: [Xen-devel] [PATCH 05/12] Add suspend\resume support for PV on HVM guests.
Date: Thu, 17 Jun 2010 16:42:08 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1006171635150.3401@kaball-desktop> (raw)
In-Reply-To: <20100614212033.GB8600@phenom.dumpdata.com>
On Mon, 14 Jun 2010, Konrad Rzeszutek Wilk wrote:
> > +static int platform_pci_resume(struct pci_dev *pdev)
> > +{
> > + int err;
> > + if (xen_have_vector_callback)
> > + return 0;
> > + err = xen_set_callback_via(callback_via);
> > + if (err) {
> > + printk("platform_pci_resume failure!\n");
>
> How did you scripts/checkpatch.pl --strict let you do that?
> You might want to use dev_err instead.
>
I'll do that and re-run checkpatch.pl on the whole series
next prev parent reply other threads:[~2010-06-17 15:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 13:10 [PATCH 01/12] Add support for hvm_op stefano.stabellini
2010-06-03 13:10 ` [PATCH 02/12] early PV on HVM stefano.stabellini
2010-06-04 20:20 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-06-07 14:38 ` Stefano Stabellini
2010-06-08 13:46 ` Konrad Rzeszutek Wilk
2010-06-08 15:55 ` Stefano Stabellini
2010-06-08 16:12 ` Konrad Rzeszutek Wilk
2010-06-08 16:25 ` Stefano Stabellini
2010-06-08 19:05 ` Konrad Rzeszutek Wilk
2010-06-10 13:36 ` Stefano Stabellini
2010-06-08 16:09 ` Jeremy Fitzhardinge
2010-06-04 20:23 ` Konrad Rzeszutek Wilk
2010-06-07 14:39 ` Stefano Stabellini
2010-06-03 13:10 ` [PATCH 03/12] evtchn delivery " stefano.stabellini
2010-06-14 21:20 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-06-17 15:41 ` Stefano Stabellini
2010-06-17 17:38 ` Konrad Rzeszutek Wilk
2010-06-17 17:40 ` Stefano Stabellini
2010-06-03 13:10 ` [PATCH 04/12] Xen PCI platform device driver stefano.stabellini
2010-06-03 13:10 ` [PATCH 05/12] Add suspend\resume support for PV on HVM guests stefano.stabellini
2010-06-14 21:20 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-06-17 15:42 ` Stefano Stabellini [this message]
2010-06-03 13:10 ` [PATCH 06/12] Allow xen platform pci device to be compiled as a module stefano.stabellini
2010-06-14 21:20 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-06-15 16:22 ` Jeremy Fitzhardinge
2010-06-17 15:42 ` Stefano Stabellini
2010-06-03 13:10 ` [PATCH 07/12] Fix find_unbound_irq in presence of ioapic irqs stefano.stabellini
2010-06-03 13:10 ` [PATCH 08/12] Fix possible NULL pointer dereference in print_IO_APIC stefano.stabellini
2010-06-03 13:10 ` [PATCH 09/12] __setup_vector_irq: handle NULL chip_data stefano.stabellini
2010-06-03 13:10 ` [PATCH 10/12] Do not try to disable hpet if it hasn't been initialized before stefano.stabellini
2010-06-03 13:10 ` [PATCH 11/12] Use xen_vcpuop_clockevent, xen_clocksource and xen wallclock stefano.stabellini
2010-06-03 13:10 ` [PATCH 12/12] Unplug emulated disks and nics stefano.stabellini
2010-06-14 21:20 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-06-17 15:42 ` Stefano Stabellini
2010-06-17 17:46 ` Konrad Rzeszutek Wilk
2010-06-17 18:00 ` Stefano Stabellini
2010-06-17 23:35 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1006171635150.3401@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=ddutile@redhat.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®