mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] input: TOUCHSCREEN_TSC2005 should depend on GENERIC_HARDIRQS
@ 2011-03-20 12:23 Geert Uytterhoeven
  2011-03-21  9:37 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2011-03-20 12:23 UTC (permalink / raw)
  To: Lauri Leukkunen, Aaro Koskinen, Srikar, Dmitry Torokhov
  Cc: Linux Kernel Development, linux-input

drivers/input/touchscreen/tsc2005.c: In function ‘tsc2005_probe’:
drivers/input/touchscreen/tsc2005.c:666: error: implicit declaration of function ‘set_irq_wake’

In addition, migrate from set_irq_wake() (marked "do not use" as of commit
a0cd9ca2b907d7ee26575e7b63ac92dad768a75e ("genirq: Namespace cleanup")) to
irq_set_irq_wake().

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/input/touchscreen/Kconfig   |    2 +-
 drivers/input/touchscreen/tsc2005.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 112ec55..434fd80 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -641,7 +641,7 @@ config TOUCHSCREEN_TOUCHIT213
 
 config TOUCHSCREEN_TSC2005
         tristate "TSC2005 based touchscreens"
-        depends on SPI_MASTER
+        depends on SPI_MASTER && GENERIC_HARDIRQS
         help
           Say Y here if you have a TSC2005 based touchscreen.
 
diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
index 8742061..437b9cd 100644
--- a/drivers/input/touchscreen/tsc2005.c
+++ b/drivers/input/touchscreen/tsc2005.c
@@ -663,7 +663,7 @@ static int __devinit tsc2005_probe(struct spi_device *spi)
 		goto err_remove_sysfs;
 	}
 
-	set_irq_wake(spi->irq, 1);
+	irq_set_irq_wake(spi->irq, 1);
 	return 0;
 
 err_remove_sysfs:
-- 
1.7.0.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] input: TOUCHSCREEN_TSC2005 should depend on GENERIC_HARDIRQS
  2011-03-20 12:23 [PATCH] input: TOUCHSCREEN_TSC2005 should depend on GENERIC_HARDIRQS Geert Uytterhoeven
@ 2011-03-21  9:37 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2011-03-21  9:37 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Lauri Leukkunen, Aaro Koskinen, Srikar, Linux Kernel Development,
	linux-input

On Sun, Mar 20, 2011 at 01:23:16PM +0100, Geert Uytterhoeven wrote:
> drivers/input/touchscreen/tsc2005.c: In function ‘tsc2005_probe’:
> drivers/input/touchscreen/tsc2005.c:666: error: implicit declaration of function ‘set_irq_wake’
> 
> In addition, migrate from set_irq_wake() (marked "do not use" as of commit
> a0cd9ca2b907d7ee26575e7b63ac92dad768a75e ("genirq: Namespace cleanup")) to
> irq_set_irq_wake().
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thank you Geert.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-21  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-20 12:23 [PATCH] input: TOUCHSCREEN_TSC2005 should depend on GENERIC_HARDIRQS Geert Uytterhoeven
2011-03-21  9:37 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®