mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: zhihua che <zhihua.che@gmail.com>,
	linux-kernel@vger.kernel.org,
	Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [Slub allocator] There are chances that kmem_cache_cpu->freelist gets lost if the process happens to be rescheduled to a differenet cpu before the local_irq_save() completes in __slab_alloc()
Date: Mon, 12 Dec 2011 09:50:02 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1112120922020.28410@router.home> (raw)
In-Reply-To: <1323702586.1765.14.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>

On Mon, 12 Dec 2011, Eric Dumazet wrote:

> We miss a deactivate_slab() call or just deliver object if c->freelist
> is not null (and NUMA node matches)
>
> Untested patch :
>
> diff --git a/mm/slub.c b/mm/slub.c
> index ed3334d..923d238 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2166,6 +2166,12 @@ redo:
>  		goto new_slab;
>  	}
>
> +#ifdef CONFIG_PREEMPT
> +	object = c->freelist;
> +	if (object)
> +		goto load_freelist;
> +#endif
> +
>  	stat(s, ALLOC_SLOWPATH);
>
>  	do {

Correct. Issue was introduced in 2.6.39.

Acked-by: Christoph Lameter <cl@linux.com>


  reply	other threads:[~2011-12-12 15:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 14:28 zhihua che
2011-12-12 15:09 ` Eric Dumazet
2011-12-12 15:50   ` Christoph Lameter [this message]
2011-12-12 17:39     ` Eric Dumazet
2011-12-12 18:53       ` Christoph Lameter
2011-12-12 19:31         ` Eric Dumazet
2011-12-13  3:57       ` Eric Dumazet
2011-12-13  4:47         ` zhihua che
2011-12-13 16:27         ` Christoph Lameter
2011-12-13 20:11           ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1112120922020.28410@router.home \
    --to=cl@linux.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=zhihua.che@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®