From: Pekka Enberg <penberg@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
zhihua che <zhihua.che@gmail.com>,
linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [Slub allocator] There are chances that kmem_cache_cpu->freelist gets lost if the process happens to be rescheduled to a differenet cpu before the local_irq_save() completes in __slab_alloc()
Date: Tue, 13 Dec 2011 22:11:58 +0200 (EET) [thread overview]
Message-ID: <alpine.LFD.2.02.1112132211350.1675@tux.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1112131025370.23111@router.home>
On Tue, 13 Dec 2011, Eric Dumazet wrote:
>> We can be interrupted and the IRQ handler can free an object an populate
>> freelist too. So the check must always be done.
On Tue, 13 Dec 2011, Christoph Lameter wrote:
> True. So a small memory leak that remained undetected. Hmm.... Wonder how
> one can create some diagnostics to allow detection of this in the future.
>
> Acked-by: Christoph Lameter <cl@linux.com>
I queued this for 3.3. Thanks guys!
Pekka
prev parent reply other threads:[~2011-12-13 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 14:28 zhihua che
2011-12-12 15:09 ` Eric Dumazet
2011-12-12 15:50 ` Christoph Lameter
2011-12-12 17:39 ` Eric Dumazet
2011-12-12 18:53 ` Christoph Lameter
2011-12-12 19:31 ` Eric Dumazet
2011-12-13 3:57 ` Eric Dumazet
2011-12-13 4:47 ` zhihua che
2011-12-13 16:27 ` Christoph Lameter
2011-12-13 20:11 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1112132211350.1675@tux.localdomain \
--to=penberg@kernel.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=zhihua.che@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®