From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1/2] xen: enter/exit lazy_mmu_mode around m2p_override calls
Date: Tue, 27 Mar 2012 17:56:16 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1203271737280.15151@kaball-desktop> (raw)
In-Reply-To: <20120327143142.GA31081@phenom.dumpdata.com>
On Tue, 27 Mar 2012, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 27, 2012 at 02:52:43PM +0100, Stefano Stabellini wrote:
> > This patch is a significant performance improvement for the
>
> How much? 10%? 90%?
I think you are overestimating the meaning of "significant" :)
It is about 6% using grant_table and 2% using blkback.
> > m2p_override.
>
> Can you explain what those calls do in the git commit description please?
Right, I have been way too concise.
Each m2p_add/remove_override call issues a MULTI_grant_table_op and a
__flush_tlb_single if kmap_op != NULL.
Batching all the calls together is a great performance benefit because
it means issuing one hypercall total rather than two hypercall per page.
I'll resend with a proper commit message.
prev parent reply other threads:[~2012-03-27 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 13:52 Stefano Stabellini
2012-03-27 13:52 ` [PATCH 2/2] m2p_find_override: use list_for_each_entry_safe Stefano Stabellini
2012-03-27 14:26 ` Konrad Rzeszutek Wilk
2012-03-27 16:37 ` Stefano Stabellini
2012-03-27 17:59 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-03-29 14:03 ` Stefano Stabellini
2012-03-27 14:31 ` [PATCH 1/2] xen: enter/exit lazy_mmu_mode around m2p_override calls Konrad Rzeszutek Wilk
2012-03-27 16:56 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1203271737280.15151@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®