From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/2] m2p_find_override: use list_for_each_entry_safe
Date: Thu, 29 Mar 2012 15:03:04 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1203291502460.15151@kaball-desktop> (raw)
In-Reply-To: <20120327175921.GB4299@andromeda.dapyr.net>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Tue, 27 Mar 2012, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 27, 2012 at 05:37:07PM +0100, Stefano Stabellini wrote:
> > On Tue, 27 Mar 2012, Konrad Rzeszutek Wilk wrote:
> > > On Tue, Mar 27, 2012 at 02:52:44PM +0100, Stefano Stabellini wrote:
> > > > Use list_for_each_entry_safe and remove the spin_lock acquisition in
> > > > m2p_find_override.
> > >
> > > So this would allow us to get stale entries. Is that OK?
> >
> > I think it is reasonable.
> > In practice we should never get an m2p_find_override call looking for an
> > entry that we are about to add/delete.
>
> Why don't you add that in the comment and also fix:
>
> /home/konrad/ssd/linux/arch/x86/xen/p2m.c: In function
> ‘m2p_find_override’:
> /home/konrad/ssd/linux/arch/x86/xen/p2m.c:810: warning: unused variable
> ‘flags’
Ooops. I'll do that.
next prev parent reply other threads:[~2012-03-29 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 13:52 [PATCH 1/2] xen: enter/exit lazy_mmu_mode around m2p_override calls Stefano Stabellini
2012-03-27 13:52 ` [PATCH 2/2] m2p_find_override: use list_for_each_entry_safe Stefano Stabellini
2012-03-27 14:26 ` Konrad Rzeszutek Wilk
2012-03-27 16:37 ` Stefano Stabellini
2012-03-27 17:59 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-03-29 14:03 ` Stefano Stabellini [this message]
2012-03-27 14:31 ` [PATCH 1/2] xen: enter/exit lazy_mmu_mode around m2p_override calls Konrad Rzeszutek Wilk
2012-03-27 16:56 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1203291502460.15151@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®