Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

[Justin Piszcz <jpiszcz@lucidpixels.com>]

On Wed, 3 Aug 2011, Justin Piszcz wrote:

>
>
> On Wed, 3 Aug 2011, Stanislaw Gruszka wrote:
>
>> On Sat, Jul 30, 2011 at 01:07:11PM -0400, Justin Piszcz wrote:
>>> Here you go, crash 2:
>>> http://home.comcast.net/~jpiszcz/20110730/2630-rt2800usb-crash2p1.jpg
>>> http://home.comcast.net/~jpiszcz/20110730/2630-rt2800usb-crash2p2.jpg
>> 
>> Here is next (draw) patch to test:
>
> Thanks,
>
> # patch -p1 < ../patch4
> patching file drivers/net/wireless/rt2x00/rt2800lib.c
> patching file drivers/net/wireless/rt2x00/rt2800lib.h
> patching file drivers/net/wireless/rt2x00/rt2800usb.c
> patching file drivers/net/wireless/rt2x00/rt2x00queue.c
> patching file drivers/net/wireless/rt2x00/rt2x00usb.c
> #
>
> I'll give this driver one more chance (quickly) and let you know if it 
> crashes
> afterwards (usually crashes in 5-10 minutes), but most likely I am going to
> move over to some other wireless usb sticks, got a couple think penguin usb
> wifi sticks that use the carl driver, 'open source' wireless usb sticks, 
> going to give them a try next.
>
> Also got some other ones as well, hopefully one of them will work without
> 900ms of lag.  The rt2870sta was the best driver in 2.6.38.x series that I
> have ever used for wireless USB sticks.
>
> Justin.
>
>

Hi,

Tested that patch:

1. The driver no longer automatically loads, I had to manually modprobe it.
2. After loading, I get this (keep getting these)

[  384.054538] phy0 -> rt2800_txdone: Error - Data pending
[  384.072773] phy0 -> rt2800_txdone: Error - Data pending
[  384.096545] phy0 -> rt2800_txdone: Error - Data pending
[  384.117301] phy0 -> rt2800_txdone: Error - Data pending
[  384.537586] phy0 -> rt2800_txdone: Error - Data pending
[  384.555716] phy0 -> rt2800_txdone: Error - Data pending
[  384.573903] phy0 -> rt2800_txdone: Error - Data pending
[  384.599465] phy0 -> rt2800_txdone: Error - Data pending
[  384.618523] phy0 -> rt2800_txdone: Error - Data pending

No crash yet, but bad ping again too (always with the rt2800usb) driver:

64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=1 ttl=64 time=53.1 ms
64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=2 ttl=64 time=285 ms
64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=3 ttl=64 time=89.6 ms
64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=4 ttl=64 time=120 ms
64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=5 ttl=64 time=42.2 ms
64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=6 ttl=64 time=156 ms
64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=7 ttl=64 time=77.2 ms

(Have another machine, testing the carl driver kernel 3.0 on it)

Not having too much luck there either.

[586342.990975] carl9170: Unknown symbol __ieee80211_get_tx_led_name (err 0)
[586342.991059] carl9170: Unknown symbol __ieee80211_get_assoc_led_name (err 0)
[586459.214057] carl9170: Unknown symbol __ieee80211_get_tx_led_name (err 0)
[586459.214131] carl9170: Unknown symbol __ieee80211_get_assoc_led_name (err 0)

Justin.