From: Julia Lawall <julia.lawall@lip6.fr>
To: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible
Date: Sun, 11 Mar 2012 22:08:51 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1203112208040.1958@localhost6.localdomain6> (raw)
In-Reply-To: <201203112058.q2BKwBCS024617@cmf.nrl.navy.mil>
On Sun, 11 Mar 2012, Chas Williams (CONTRACTOR) wrote:
> i am pretty sure that request_irq() shouldnt be changed but rather
> free_irq() changed. the last argument of request_irq() is passed to the
> interrupt routine (ent_int in this case). if you change that you need
> to update the interrupt routine. fixing free_irq would be easier.
OK, thanks for the feedback. I will fix it up.
julia
>
> In message <1331494587-12196-6-git-send-email-Julia.Lawall@lip6.fr>,Julia Lawall writes:
>> Convert call to request_irq so that the last argument is the same as the
>> second argument of the subsequent call to free_irq. Without this
>> property, free_irq does nothing.
>>
>> I have chosen to keep the call to free_irq as is, because its second
>> argument is more like its first argument.
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-03-11 21:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 19:36 [PATCH 0/7] " Julia Lawall
2012-03-11 19:36 ` [PATCH 1/7] drivers/video/pvr2fb.c: " Julia Lawall
2012-03-21 18:37 ` Florian Tobias Schandinat
2012-03-11 19:36 ` [PATCH 2/7] drivers/scsi/arm/{cumana_2,eesox,powertec}.c: " Julia Lawall
2012-03-11 19:36 ` [PATCH 3/7] drivers/net/irda/{ali-ircc,via-ircc,w83977af-ir}.c: " Julia Lawall
2012-03-11 19:36 ` [PATCH 4/7] arch/sh/drivers/dma/{dma-g2,dmabrg}.c: " Julia Lawall
2012-03-15 6:14 ` Paul Mundt
2012-03-11 19:36 ` [PATCH 5/7] drivers/atm/eni.c: " Julia Lawall
2012-03-11 20:58 ` Chas Williams (CONTRACTOR)
2012-03-11 21:08 ` Julia Lawall [this message]
2012-03-11 21:16 ` Julia Lawall
2012-03-11 22:42 ` David Miller
2012-03-11 19:36 ` [PATCH 6/7] drivers/input/touchscreen/hp680_ts_input.c: " Julia Lawall
2012-03-11 23:06 ` Dmitry Torokhov
2012-03-11 19:36 ` [PATCH 7/7] arch/unicore32/kernel/dma.c: " Julia Lawall
2012-03-12 0:58 ` Guan Xuetao
2012-03-12 5:27 ` Julia Lawall
2012-03-13 7:10 ` Guan Xuetao
2012-03-13 8:23 ` Julia Lawall
2012-03-14 8:07 ` Guan Xuetao
2012-03-14 8:19 ` Dan Carpenter
2012-03-14 8:42 ` Guan Xuetao
2012-03-14 9:23 ` Julia Lawall
2012-03-15 1:01 ` Guan Xuetao
2012-03-15 6:10 ` Julia Lawall
2012-03-15 8:07 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1203112208040.1958@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=chas@cmf.nrl.navy.mil \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®