From: Julia Lawall <julia.lawall@lip6.fr>
To: David Miller <davem@davemloft.net>
Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com, julia@diku.dk
Subject: Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit operation
Date: Fri, 8 Jun 2012 07:12:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1206080711370.1793@hadrien> (raw)
In-Reply-To: <20120607.144616.2224976714259476349.davem@davemloft.net>
On Thu, 7 Jun 2012, David Miller wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> Date: Wed, 6 Jun 2012 23:41:35 +0200
>
>> - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {
>> + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH)
>
> I'm really surprised someone as thorough as yourself did not
> compile test this.
Sorry, I changed the patch at the last minute, and it was indeed not a
good idea not to have compiled again. I will send another version, in
case it is useful.
julia
next prev parent reply other threads:[~2012-06-08 5:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:41 [PATCH 0/7] " Julia Lawall
2012-06-06 21:41 ` [PATCH 1/7] drivers/ide/ide-cs.c: " Julia Lawall
2012-06-07 21:46 ` David Miller
2012-06-07 21:59 ` Joe Perches
2012-06-08 5:12 ` Julia Lawall [this message]
2012-06-08 5:14 ` Julia Lawall
2012-06-11 23:43 ` David Miller
2012-06-12 14:17 ` Julia Lawall
2012-06-12 22:52 ` David Miller
2012-06-06 21:41 ` [PATCH 2/7] drivers/staging/comedi/drivers/me4000.c: " Julia Lawall
2012-06-06 21:41 ` [PATCH 3/7] drivers/usb/gadget/pch_udc.c: " Julia Lawall
2012-06-07 13:00 ` Sergei Shtylyov
2012-06-07 14:23 ` Julia Lawall
2012-06-07 15:05 ` Joe Perches
2012-06-08 12:58 ` Dan Carpenter
2012-06-08 15:28 ` Joe Perches
2012-06-06 21:41 ` [PATCH 4/7] fs/direct-io.c: " Julia Lawall
2012-06-07 14:24 ` Jeff Moyer
2012-06-06 21:41 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: " Julia Lawall
2012-06-06 23:43 ` Franky Lin
2012-06-06 21:41 ` [PATCH 6/7] drivers/ata/pata_pcmcia.c: " Julia Lawall
2012-06-06 21:41 ` [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: " Julia Lawall
2012-06-06 21:52 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1206080711370.1793@hadrien \
--to=julia.lawall@lip6.fr \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®