From: Jeff Moyer <jmoyer@redhat.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, joe@perches.com,
Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH 4/7] fs/direct-io.c: adjust suspicious bit operation
Date: Thu, 07 Jun 2012 10:24:46 -0400 [thread overview]
Message-ID: <x49bokvb3o1.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1339018901-28439-5-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Wed, 6 Jun 2012 23:41:38 +0200")
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> READ is 0, so the result of the bit-and operation is 0. Rewrite with == as
> done elsewhere in the same file.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
Interesting catch, that one. Yeah, we don't expect any readahead I/O to
be done via O_DIRECT. The test for rw == READ all over that file seems
fine to me, given that.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2012-06-07 14:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:41 [PATCH 0/7] " Julia Lawall
2012-06-06 21:41 ` [PATCH 1/7] drivers/ide/ide-cs.c: " Julia Lawall
2012-06-07 21:46 ` David Miller
2012-06-07 21:59 ` Joe Perches
2012-06-08 5:12 ` Julia Lawall
2012-06-08 5:14 ` Julia Lawall
2012-06-11 23:43 ` David Miller
2012-06-12 14:17 ` Julia Lawall
2012-06-12 22:52 ` David Miller
2012-06-06 21:41 ` [PATCH 2/7] drivers/staging/comedi/drivers/me4000.c: " Julia Lawall
2012-06-06 21:41 ` [PATCH 3/7] drivers/usb/gadget/pch_udc.c: " Julia Lawall
2012-06-07 13:00 ` Sergei Shtylyov
2012-06-07 14:23 ` Julia Lawall
2012-06-07 15:05 ` Joe Perches
2012-06-08 12:58 ` Dan Carpenter
2012-06-08 15:28 ` Joe Perches
2012-06-06 21:41 ` [PATCH 4/7] fs/direct-io.c: " Julia Lawall
2012-06-07 14:24 ` Jeff Moyer [this message]
2012-06-06 21:41 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: " Julia Lawall
2012-06-06 23:43 ` Franky Lin
2012-06-06 21:41 ` [PATCH 6/7] drivers/ata/pata_pcmcia.c: " Julia Lawall
2012-06-06 21:41 ` [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: " Julia Lawall
2012-06-06 21:52 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49bokvb3o1.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=Julia.Lawall@lip6.fr \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®