From: Petko Manolov <petkan@nucleusys.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup
Date: Sun, 19 May 2013 11:42:06 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1305191136360.4537@fry.nucleusys.com> (raw)
In-Reply-To: <20130518210948.GA26590@electric-eye.fr.zoreil.com>
On Sat, 18 May 2013, Francois Romieu wrote:
> Petko Manolov <petkan@nucleusys.com> :
> > From: Petko Manolov <petkan@nucleusys.com>
> >
> > Moving constant and structure definitions out of rtl8150.c;
>
> What's the point ?
The general logic of having .h files applies.
> [...]
> > ---
> > drivers/net/usb/rtl8150.c | 121 +----------------------------------
> > 1 file changed, 2 insertions(+), 119 deletions(-)
> >
> > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> > index a491d3a..7d1897b 100644
> > --- a/drivers/net/usb/rtl8150.c
> > +++ b/drivers/net/usb/rtl8150.c
> > @@ -17,132 +17,15 @@
> > #include <linux/usb.h>
> > #include <asm/uaccess.h>
> >
> > +#include "rtl8150.h"
>
> It won't compile. You shouldn't do that.
It does compile. Both inside and outside of the tree.
If the proper place for rtl8150.h is somewhere in include/linux/... then
it is different matter.
next prev parent reply other threads:[~2013-05-19 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 16:23 Petko Manolov
2013-05-18 21:09 ` Francois Romieu
2013-05-19 8:42 ` Petko Manolov [this message]
2013-05-19 19:01 ` Francois Romieu
2013-05-20 6:58 ` Petko Manolov
2013-05-20 7:00 ` David Miller
2013-05-20 7:09 ` Petko Manolov
2013-05-20 7:12 ` David Miller
2013-05-20 7:18 ` Petko Manolov
2013-05-20 7:43 ` David Miller
2013-05-20 7:49 ` Petko Manolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1305191136360.4537@fry.nucleusys.com \
--to=petkan@nucleusys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®