From: Petko Manolov <petkan@nucleusys.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup
Date: Mon, 20 May 2013 09:58:39 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1305200941260.4719@fry.nucleusys.com> (raw)
In-Reply-To: <20130519190116.GA4019@electric-eye.fr.zoreil.com>
On Sun, 19 May 2013, Francois Romieu wrote:
> Which one ?
> - share it through the kernel or with userspace
> - personal choice .c split
It is obviously not the former. I think that in general constant and
other definitions (in their majority) should be in a header file. I
definitely like this way better.
Perhaps in this particular case my patch is a bit of an overkill as the
code lines aren't that many. If the consensus is in this direction i'll
revert this part of the series.
> I don't mind the later even if it does not exactly apply to a
> WIP driver. I'd still avoid future copycat followers though.
This isn't WIP anymore as the W(ork) part is missing. After so many quiet
years i assume the experimental tag should be removed.
> The rtl8150.h file is created in patch #2. This is patch #1.
>
> So...
So first apply patch #1 and then patch #2.
However, if it is required for the driver to be in build-able form after
applying any single patch i'll coalesce #1 and #2 before next submission.
David?
Petko
next prev parent reply other threads:[~2013-05-20 6:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 16:23 Petko Manolov
2013-05-18 21:09 ` Francois Romieu
2013-05-19 8:42 ` Petko Manolov
2013-05-19 19:01 ` Francois Romieu
2013-05-20 6:58 ` Petko Manolov [this message]
2013-05-20 7:00 ` David Miller
2013-05-20 7:09 ` Petko Manolov
2013-05-20 7:12 ` David Miller
2013-05-20 7:18 ` Petko Manolov
2013-05-20 7:43 ` David Miller
2013-05-20 7:49 ` Petko Manolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1305200941260.4719@fry.nucleusys.com \
--to=petkan@nucleusys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®